Skip to content
This repository has been archived by the owner on Apr 22, 2021. It is now read-only.

Class lookup (move #303 to refactored branch) #317

Merged
merged 13 commits into from
Mar 29, 2020
Merged

Conversation

5HT2
Copy link
Member

@5HT2 5HT2 commented Dec 20, 2019

Closes #295

@5HT2 5HT2 mentioned this pull request Dec 20, 2019
@5HT2 5HT2 added this to the v1.1.3 milestone Dec 26, 2019
@5HT2 5HT2 modified the milestones: v1.1.3, v1.1.4, v1.1.5 Jan 14, 2020
@5HT2 5HT2 self-assigned this Jan 15, 2020
@5HT2 5HT2 mentioned this pull request Jan 15, 2020
20 tasks
@5HT2

This comment has been minimized.

@5HT2 5HT2 added 3 - Review --review-pending Pending a review of the pull labels Feb 17, 2020
@5HT2

This comment has been minimized.

@5HT2 5HT2 added bug/other and removed 3 - Review --review-pending Pending a review of the pull labels Feb 17, 2020
@5HT2 5HT2 added the -blocked Something is preventing this from being possible label Feb 26, 2020
@5HT2 5HT2 modified the milestones: v1.1.5, v1.1.3 Mar 8, 2020
@5HT2
Copy link
Member Author

5HT2 commented Mar 8, 2020

@cookiedragon234 could you please take a look at this? Even before I fixed all the merge conflicts, the class-lookup branch didn't launch, with the same error as it currently does.

Caused by: org.spongepowered.asm.mixin.throwables.MixinApplyError: Mixin [mixins.kami.json:MixinAbstractClientPlayer] from phase [DEFAULT] in config [mixins.kami.json] FAILED during PREPARE
Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTargetAlreadyLoadedException: Critical problem: mixins.kami.json:MixinAbstractClientPlayer target net.minecraft.client.entity.AbstractClientPlayer was already transformed.

@EmotionalLove aaaa I finally got around to merging this and it doesn't work, nor does it before I fixed merge conflicts smh

@x4e
Copy link
Contributor

x4e commented Mar 8, 2020

Sounds like you have multiple mixins. Maybe there are multiple classes that target the same class in the Mixin annotation, or you referenced a class twice in the mixins.whatever.json @S-B99

@5HT2
Copy link
Member Author

5HT2 commented Mar 8, 2020

Talked to cookie on discord, I don't have duplicate @ Mixin annotations anywhere, nor duplicate mixin registers in mixins.kami.json

I created an issue in the Mixin GitHub here: SpongePowered/Mixin/issues/388

@Vonr
Copy link
Contributor

Vonr commented Mar 8, 2020

omg cookiedragon is alive???

@x4e
Copy link
Contributor

x4e commented Mar 8, 2020

@Vonr no

@5HT2
Copy link
Member Author

5HT2 commented Mar 9, 2020

Fixed, merging later today.

@5HT2
Copy link
Member Author

5HT2 commented Mar 13, 2020

Waiting for #521 to merge

@5HT2 5HT2 merged commit 01ad7a7 into feature/master Mar 29, 2020
@5HT2 5HT2 deleted the class-lookup branch March 29, 2020 23:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
-blocked Something is preventing this from being possible -other bug enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleManager lookup by class, not name
4 participants