Failing to launch, MixinTargetAlreadyLoadedException

[5HT2]

If you try to launch the class-lookup branch of my repo, you'll get this error.

Caused by: org.spongepowered.asm.mixin.throwables.MixinApplyError: Mixin [mixins.kami.json:MixinAbstractClientPlayer] from phase [DEFAULT] in config [mixins.kami.json] FAILED during PREPARE

Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTargetAlreadyLoadedException: Critical problem: mixins.kami.json:MixinAbstractClientPlayer target net.minecraft.client.entity.AbstractClientPlayer was already transformed.

You can clone it with git clone -b class-lookup https://github.com/S-B99/kamiblue and find instructions to setup a workspace here: https://blue.bella.wtf/contributing

The changed files can be found here :https://github.com/S-B99/kamiblue/pull/317/files

The only changes in Mixin related files is changing the class lookup manager, as you can see shown in the link but you can check for yourself.

I don't have duplicate @ Mixin annotations anywhere, nor duplicate mixin registers in mixins.kami.json

[Johni0702]

Not 100% sure if it's the issue as I don't see why it would only pop up with that PR but your coremod is loading your normal mod class and executing its static initializer (ref).
That'll cause anything in there to be loaded before Mixin is initialized and potentially (I am not particularly familiar with how forge sets up its classloaders) also cause those classes and anything they load to end up with the wrong classloader.

[5HT2]

I'm not quite sure how it works either, and something that changed in the pull had to have done it as it only happens there, but nothing mixin related changed.

Maybe the module lookup somehow tries to load a module before mixins? It shouldn't happen but it's possible, as from what I can tell modules are loaded even if mc.player is null (ie, modules load even when not loaded into a world) but I shouldn't have an issue from that, as the issue here is that a Mixin is already loaded when it tried loading it.

[Johni0702]

No, what I was trying to say is that loading non-coremod classes from your coremod is not allowed (i.e. once you do it, all bets are off) and the specific error you're getting would perfectly fit that.
I'm just not 100% sure because do not see exactly how those changes cause the AbstractClientPlayer class to get loaded prior to mixin being ready for it (maybe because I only skimmed them) but I would not at all be surprised if they did.
You should remove that line and try again.

[5HT2]

Which line exactly? You mean this diff? If so, it happens before I merged feature/master into it to fix the merge conflicts.

[Johni0702]

The one I linked in my first reply: https://github.com/S-B99/kamiblue/blob/cf3207db8845d7311a4eb230f247e3252667525b/src/main/java/me/zeroeightsix/kami/mixin/MixinLoaderForge.java#L16
And also the last line of the same method (i.e. any reference to the KamiMod class).

[5HT2]

Uh, that fixed it? I think?

[5HT2]

Yep, launched. Not 100% sure why that was the issue. Thanks!