Feature/attachment headers #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jarrodmoldrich. Thank you for your contribution to the library. Let's wait until your bamboo PR is merged. |
This change in contingent upon an update to the bamboo library to include a `:headers` key in `Bamboo.Attachment` that holds a keyword list of headers that will override *all* others. For e.g., in the specific use-case of adding inlined attachments, some special case headers are required. Now it's possible to add `X-Attachment-Id` and override the Content-Disposition header with `inline` to permit the proper display of inlined content, without an email client showing them as explicit attachments for the user to download.
... and fix tests
This reverts commit 0e2a74c.
jarrodmoldrich
force-pushed
the
feature/attachment_headers
branch
from
616cd2e
to
d575a0e
Compare
|
@kalys I'm being asked to wrap up work on the related PRs, so just need you to remind me of one thing. Did you close this because you already added the functionality in another merge? |
|
@jarrodmoldrich Yes. Since then I overhauled generation of the mail body. elixir-mail is not used anymore. And |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kalys 👋
In a related PR to
thoughtbot/bambooI've exposed a variable inBamboo.Attachmentcalled:headersthat can pass a number of arbitrary headers as a keyword list, permitting overrides of headers (e.g.,Content-Disposition) or adding other special cases (e.g.,X-Content-Id). The purpose is to give extra control to the library consumer, and the benefit for me, in particular, is to add inline image attachments that work well in a variety of email clients.As well as these extra headers, there's a need to reorganize and wrap the inline attachments in a
multipart/relatedpart. I'll be pushing another related PR for that to DockYard/elixir-mail shortly, but I also duplicated the changes to theRFC2822Renderermodule in this library. The update shouldn't regress any prior behavior, and I feel that the new code is appreciably more legible. From my testing, inline images now work properly in Outlook webmail with this change.I haven't added anything to test suite yet, but will proceed to work on this PR if I have your blessing. So please let me know!
Cheers,
Jarrod
Related PRs:
beam-community/bamboo#631
DockYard/elixir-mail#137