feat: Add arbitrary header overrides for attachments #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows bamboo adapters to be accept overriding headers for special use cases. Updates to those adapters would be required to use this functionality. For e.g., in the specific use-case of adding inlined attachments, some special case headers are required. Now it's possible to add `X-Attachment-Id` and override the Content-Disposition header with `inline` to permit the proper display of inlined content, without an email client showing them as explicit attachments for the user to download.
This was referenced Oct 22, 2021
|
Hi @jarrodmoldrich! Now that BEAM Community is taking over Bamboo we're working through these older PRs. Would you like to update this PR or should we close? |
|
@doomspork Hi there! I probably won't be testing this against SES as I've retired the infra I was using, but I'll get the PR up-to-date and to a working state in the coming weeks. |
doomspork
changed the title
|
Amazing, thank you @jarrodmoldrich! |
…aders Keep headers: key/value in tests after merge conflict
|
@doomspork This is ready for another look (assuming it passes your CI) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows bamboo adapters to be accept overriding headers for special
use cases. Updates to those adapters would be required to use this
functionality.
For e.g., in the specific use-case of adding inlined attachments, some
special case headers are required. Now it's possible to add
X-Attachment-Idand override the Content-Disposition header withinlineto permit the proper display of inlined content, without anemail client showing them as explicit attachments for the user to
download.
Closes #502 #430
Related PRs:
kalys/bamboo_ses#43
DockYard/elixir-mail#137