Proposal: Move nullability inside WGPURenderPassDepthStencilAttachment

Fixes webgpu-native#408
kainino0x · Nov 12, 2024 · 28689af · 28689af
1 parent f848447
commit 28689af
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/webgpu.h b/webgpu.h
@@ -1630,6 +1630,9 @@ typedef struct WGPURenderBundleEncoderDescriptor {
 } WGPURenderBundleEncoderDescriptor WGPU_STRUCTURE_ATTRIBUTE;
 
 typedef struct WGPURenderPassDepthStencilAttachment {
+    /**
+     * Texture view to use as a depth/stencil attachment. Null indicates there is no attachment; other fields are ignored.
+     */
     WGPUTextureView view;
     WGPULoadOp depthLoadOp;
     WGPUStoreOp depthStoreOp;
@@ -2158,7 +2161,7 @@ typedef struct WGPURenderPassDescriptor {
     WGPUStringView label;
     size_t colorAttachmentCount;
     WGPURenderPassColorAttachment const * colorAttachments;
-    WGPU_NULLABLE WGPURenderPassDepthStencilAttachment const * depthStencilAttachment;
+    WGPURenderPassDepthStencilAttachment depthStencilAttachment;
     WGPU_NULLABLE WGPUQuerySet occlusionQuerySet;
     WGPU_NULLABLE WGPURenderPassTimestampWrites const * timestampWrites;
 } WGPURenderPassDescriptor WGPU_STRUCTURE_ATTRIBUTE;

diff --git a/webgpu.yml b/webgpu.yml
@@ -2341,7 +2341,7 @@ structs:
     members:
       - name: view
         doc: |
-          TODO
+          Texture view to use as a depth/stencil attachment. Null indicates there is no attachment; other fields are ignored.
         type: object.texture_view
       - name: depth_load_op
         doc: |
@@ -2393,8 +2393,6 @@ structs:
         doc: |
           TODO
         type: struct.render_pass_depth_stencil_attachment
-        pointer: immutable
-        optional: true
       - name: occlusion_query_set
         doc: |
           TODO