Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ULID.valid_as_variants? with ULID.valid? deprecation #205

Merged
merged 1 commit into from
Jul 3, 2022
Merged

Implement ULID.valid_as_variants? with ULID.valid? deprecation #205

merged 1 commit into from
Jul 3, 2022

Conversation

kachick
Copy link
Owner

@kachick kachick commented Jul 3, 2022

ref: #57 #143, #78

@kachick kachick added the enhancement New feature or request label Jul 3, 2022
Base automatically changed from strict-typing to main July 3, 2022 04:55
@kachick kachick force-pushed the valid_as_variants branch from 7c19522 to fa026b2 Compare July 3, 2022 08:47
@kachick kachick marked this pull request as ready for review July 3, 2022 08:53
@kachick kachick merged commit 5163465 into main Jul 3, 2022
@kachick kachick deleted the valid_as_variants branch July 3, 2022 08:55
@kachick kachick mentioned this pull request Jul 3, 2022
Merged
kachick added a commit that referenced this pull request Jul 3, 2022
@kachick
Implement ULID.parse_variant_format (#206)
bef91dc 
Closes #143
Resolves #57
Resolves #78
Updates #205 (Renamed non released method)
kachick
kachick commented Jul 3, 2022
View reviewed changes
steep_expectations.yml
Comment on lines +11 to +13
severity: ERROR
message: Type `singleton(::Warning)` does not have method `warn`
code: Ruby::NoMethod
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope ruby/rbs#1056 removes this 🙏

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c5a9740

kachick added a commit that referenced this pull request Aug 7, 2022
@kachick
Drop deprecated ULID.valid? since #205
e472b99
@kachick kachick mentioned this pull request Aug 7, 2022
Merged
kachick added a commit that referenced this pull request Aug 7, 2022
@kachick
Drop deprecated ULID.valid? since #205 (#239)
a5a5582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kachick