Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should accept O, o, I, i, L, l, and - in the parser? #57

Closed
kachick opened this issue May 1, 2021 · 0 comments · Fixed by #206
Closed

Should accept O, o, I, i, L, l, and - in the parser? #57

kachick opened this issue May 1, 2021 · 0 comments · Fixed by #206
Labels
question Further information is requested

Comments

@kachick
Copy link
Owner

kachick commented May 1, 2021

ref: ulid/javascript#85, https://www.crockford.com/base32.html, ulid/spec#38

In my understanding, Crockford's base32 does not contain L for the encoded product. So ULID can ignore L

This is my understanding. 🤔
If not, the string based sort oder will be complex?
@kachick kachick added the question Further information is requested label May 1, 2021
@kachick kachick mentioned this issue May 1, 2021
Closed
@kachick kachick changed the title Should be accept I, i and L, l in the parser? Should be accept O, o, I, i and L, l in the parser? May 1, 2021
This was referenced May 1, 2021
Open
Closed
@kachick kachick changed the title Should be accept O, o, I, i and L, l in the parser? Should accept O, o, I, i, L, l, and - in the parser? May 1, 2021
This was referenced May 4, 2021
Closed
Closed
kachick added a commit that referenced this issue May 7, 2021
@kachick
Simplify ULID#===
b7e806a 
Might be changed in #57 and ulid/spec#57
But this is enough for now
This was referenced May 15, 2021
Closed
Closed
kachick added a commit that referenced this issue May 17, 2021
@kachick
Implement ULID.normalize and ULID.normalized?
28d4496 
Resolves #150

This is a simple solution for following issues

* #78
* #57
* #143
* ulid/spec#57
* ulid/spec#3
@kachick kachick mentioned this issue May 17, 2021
Merged
This was referenced Jul 3, 2022
Merged
Merged
Merged
kachick added a commit that referenced this issue Jul 3, 2022
@kachick
Implement ULID.parse_variant_format (#206)
bef91dc 
Closes #143
Resolves #57
Resolves #78
Updates #205 (Renamed non released method)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement ULID.parse_variant_format kachick/ruby-ulid
1 participant
@kachick