remove all vendoring #294
Merged
remove all vendoring #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffromani
reviewed
May 21, 2024
Makefile
Outdated
| _out/git-semver: outdir | ||
| @go build -o _out/git-semver vendor/github.com/mdomke/git-semver/main.go | ||
| @GOBIN=$(shell pwd)/_out go install github.com/mdomke/git-semver/v6@latest |
There was a problem hiding this comment.
floating tags created a lot of pain in the past. Let's use [email protected] or any fixed, non-floating tag you prefer.
ffromani
reviewed
May 21, 2024
The `vendor/` directory makes mirror maintenance unnecessarily painful. Modern Go and modules are a cleaner, more maintainable way to manage dependencies. This patch removes all use of Go vendoring and updates the Makefile targets to install dependent test tooling like `mockery` and `git-semver` into the `_out/` directory instead of looking in a `vendor/` directory. Issue k8stopologyawareschedwg#293 Signed-off-by: Jay Pipes <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
vendor/directory makes mirror maintenance unnecessarily painful. Modern Go and modules are a cleaner, more maintainable way to manage dependencies.This patch removes all use of Go vendoring and updates the Makefile targets to install dependent test tooling like
mockeryandgit-semverinto the_out/directory instead of looking in avendor/directory.Issue #293