Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of vendoring #293

Closed
jaypipes opened this issue May 21, 2024 · 2 comments
Closed

Get rid of vendoring #293

jaypipes opened this issue May 21, 2024 · 2 comments

Comments

@jaypipes
Copy link
Contributor

We (Microsoft Network Cloud) have a mirror of this repo internally for software supply chain purposes and the vendor/ directory makes the mirror maintenance unnecessarily painful. Modern Go and modules are a cleaner, more maintainable way to manage dependencies.
jaypipes added a commit to jaypipes/k8s-resource-topology-exporter that referenced this issue May 21, 2024
@jaypipes
remove all vendoring
bc51704 
The `vendor/` directory makes mirror maintenance unnecessarily painful.
Modern Go and modules are a cleaner, more maintainable way to manage
dependencies.

This patch removes all use of Go vendoring and updates the Makefile
targets to install dependent test tooling like `mockery` and
`git-semver` into the `_out/` directory instead of looking in a
`vendor/` directory.

Issue k8stopologyawareschedwg#293

Signed-off-by: Jay Pipes <[email protected]>
@jaypipes jaypipes mentioned this issue May 21, 2024
Merged
@ffromani
Copy link
Contributor

I do have nothing against removing vendor/ in principle. Let's see how we want to do it.

jaypipes added a commit to jaypipes/k8s-resource-topology-exporter that referenced this issue May 21, 2024
@jaypipes
remove all vendoring
e2a9d50 
The `vendor/` directory makes mirror maintenance unnecessarily painful.
Modern Go and modules are a cleaner, more maintainable way to manage
dependencies.

This patch removes all use of Go vendoring and updates the Makefile
targets to install dependent test tooling like `mockery` and
`git-semver` into the `_out/` directory instead of looking in a
`vendor/` directory.

Issue k8stopologyawareschedwg#293

Signed-off-by: Jay Pipes <[email protected]>
@ffromani
Copy link
Contributor

closed thanks to #294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaypipes @ffromani