[release-0.20][manual] support for custom and default selinux policies #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're using MachineConfig for installing custom SELinux policy. We want to depracate the custom policy, hence we make the MachineConfig as opt-in and we're deploying/rendering it unless specifically asked by the user. Signed-off-by: Talor Itzhak <[email protected]> (cherry picked from commit fee7ce3)
The `container_device_plugin_t` label type, allows communication with `kubelet_t` context: containers/container-selinux#178. The PodResourceAPI socket is an object created by Kubelet so it inherents the same process context, i.e. `kubelet_t`. We gradually want to depracate the custom SELinux context and use this one instead. Signed-off-by: Talor Itzhak <[email protected]> (cherry picked from commit 170037a)
Add the `UpdaterCustomSELinuxPolicy` flag so we could control whether we want to install custom policy from the deployer directly. This flag is off by default. Signed-off-by: Talor Itzhak <[email protected]> (cherry picked from commit 88ca7b2)
There were few places where we forgot to pass the `UpdaterCustomSELinuxPolicy` option. This commit is suppose to fix that. Signed-off-by: Talor Itzhak <[email protected]> (cherry picked from commit 16e4670)
Signed-off-by: Talor Itzhak <[email protected]> (cherry picked from commit 6aec6fd)
in 0.21 and beyond the default must be to use the native selinux policy, but in backports we must preserve backward compatibility and keep defaulting to the custom one while being forward looking. Signed-off-by: Francesco Romani <[email protected]>
|
LGTM |
|
let's see if we can avoid the backports because it creates almost more problems as it solves it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggregate backport of #311 #313 #319 (partial) #320 (partial)