Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selinux: allow access to kubelet_var_lib_t #320

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

Tal-or
Copy link
Contributor

@Tal-or Tal-or commented Sep 24, 2024

podresources API context has changed to kubelet_var_lib_t:
containers/container-selinux#329

Adjust the custom policy to allow access to this new file context.

Signed-off-by: Talor Itzhak [email protected]

@ffromani
Copy link
Collaborator

LGTM!
any chance to have (more) unit test? even something extremely basic like making sure the (correct) policy is returned would be OK

@Tal-or
Copy link
Contributor Author

Tal-or commented Sep 24, 2024

LGTM! any chance to have (more) unit test? even something extremely basic like making sure the (correct) policy is returned would be OK

I'll verify manually and update. Please do not merge unless state otherwise

podresources API context has changed to kubelet_var_lib_t:
 containers/container-selinux#329

Adjust the custom policy to allow access to this new file context.

Signed-off-by: Talor Itzhak <[email protected]>
This test is to make sure that when user adds a cil file
for a newer version,
he doesn't forget to update the known version slice.

Signed-off-by: Talor Itzhak <[email protected]>
Copy link
Collaborator

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, good enough for now

@ffromani ffromani merged commit b7af938 into main Sep 25, 2024
4 checks passed
@ffromani ffromani deleted the fix_selinux_policy branch September 25, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants