Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.12] scheduler: update: use unstructured in RenderConfig #236

Conversation

ffromani
Copy link
Collaborator

Rewrite RenderConfig to use unstructured vs typed API.
The rationale for this change is that doing so will enable us to drop all the dependencies to the scheduler-plugins
API packages, which pull the scheduler API package, which eventually pulls in k8s.io/kubernetes, which we should
really NOT depend on.

We take the change to improve the RenderConfig API and make it forward extensible, anticipating the future support
for more scheduler plugin parameters.

The end result in terms of rendered YAML is expected to be not 1:1 indentical, but fully compatible.

bump ubuntu image to 22.04
bump kind cluster image to 1.25.z latest

Signed-off-by: Francesco Romani <[email protected]>
these tests are cheap, let's do them.

Signed-off-by: Francesco Romani <[email protected]>
Rewrite RenderConfig to use `unstructured` vs typed API.
The rationale for this change is that doing so will
enable us to drop all the dependencies to the scheduler-plugins
API packages, which pull the scheduler API package, which
eventually pulls in k8s.io/kubernetes, which we should
really NOT depend on.

We take the change to improve the RenderConfig API and make
it forward extensible, anticipating the future support
for more scheduler plugin parameters.

The end result in terms of rendered YAML is expected
to be not 1:1 indentical, but fully compatible.

0.13.z backport note: added manifets.RenderObjects

Signed-off-by: Francesco Romani <[email protected]>
no longer needed; the RenderConfig code uses
unstructured now.

Signed-off-by: Francesco Romani <[email protected]>
We use unstructured now, so we no longer depend
on the API packages.

Signed-off-by: Francesco Romani <[email protected]>
@ffromani ffromani merged commit 72d96ef into k8stopologyawareschedwg:release-0.12 Oct 24, 2023
1 check passed
@ffromani ffromani deleted the sched-config-render-unstruct-0.12 branch October 24, 2023 11:52
@ffromani
Copy link
Collaborator Author

backport of #225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant