scheduler: update: use unstructured in RenderConfig #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold looks promising, but needs more testing |
Tal-or
reviewed
Oct 23, 2023
ffromani
force-pushed
the
sched-config-render-unstruct
branch
2 times, most recently
from
e5620a6 to
8cea7cb
Compare
The Scheduler Profile Name field was supposed to be passed down the stack, but it wasn't because of a overlook. Previously the mistake was dormant, but the upcoming scheduler.RenderConfig changes will trigger this. Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
sched-config-render-unstruct
branch
from
8cea7cb to
f301ac3
Compare
ffromani
force-pushed
the
sched-config-render-unstruct
branch
from
f301ac3 to
dfaa249
Compare
Rewrite RenderConfig to use `unstructured` vs typed API. The rationale for this change is that doing so will enable us to drop all the dependencies to the scheduler-plugins API packages, which pull the scheduler API package, which eventually pulls in k8s.io/kubernetes, which we should really NOT depend on. We take the change to improve the RenderConfig API and make it forward extensible, anticipating the future support for more scheduler plugin parameters. The end result in terms of rendered YAML is expected to be not 1:1 indentical, but fully compatible. Signed-off-by: Francesco Romani <[email protected]>
no longer needed; the RenderConfig code uses unstructured now. Signed-off-by: Francesco Romani <[email protected]>
We use unstructured now, so we no longer depend on the API packages. Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
sched-config-render-unstruct
branch
from
7d47b1d to
bb37528
Compare
This was referenced Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite RenderConfig to use
unstructuredvs typed API.The rationale for this change is that doing so will enable us to drop all the dependencies to the scheduler-plugins
API packages, which pull the scheduler API package, which eventually pulls in k8s.io/kubernetes, which we should
really NOT depend on.
We take the change to improve the RenderConfig API and make it forward extensible, anticipating the future support
for more scheduler plugin parameters.
The end result in terms of rendered YAML is expected to be not 1:1 indentical, but fully compatible.