Add additional supported MLNX device IDs

[adrianchiris]

This commit adds the following NIC modes to the
supported devices map:

1. ConnectX5 Ex
2. ConnectX6 Dx

Signed-off-by: Adrian Chiris [email protected]

[adrianchiris]

I will update Quickstart guide once #71 is merged.
Or if this lands first then add these two devices to the PR.

These NICs are tested internally within nvidia.

In general i dont think we should keep an explicit list of devices as this list might get unbearingly long.
for Openshift or other platforms we can allow to filter supported device according to configMap.

[zshi-redhat]

I will update Quickstart guide once #71 is merged.
Or if this lands first then add these two devices to the PR.

These NICs are tested internally within nvidia.

In general i dont think we should keep an explicit list of devices as this list might get unbearingly long.

@adrianchiris just to understand, are you suggesting to remove the NicIdMap?

[adrianchiris]

@adrianchiris just to understand, are you suggesting to remove the NicIdMap?

Yes, This is something i'd like to discuss, however this does not relate to this PR.

[zshi-redhat]

@adrianchiris just to understand, are you suggesting to remove the NicIdMap?

Yes, This is something i'd like to discuss, however this does not relate to this PR.

Ok, the NicIdMap is used for generating device plugin configmap and/or perhaps in other code path (operator-webhook).
If we can find a way to remove all those direct uses of NicIdMap, I agree that we could delete it and allows more NICs to be used with SR-IOV Operator directly.

[adrianchiris]

Ok, the NicIdMap is used for generating device plugin configmap and/or perhaps in other code path (operator-webhook).
If we can find a way to remove all those direct uses of NicIdMap, I agree that we could delete it and allows more NICs to be used with SR-IOV Operator directly.

Will open an issue to track !

Could you review this commit :)

[zshi-redhat]

@adrianchiris would you like to update the doc in this PR, this one #71 is merged.

[adrianchiris]

@zshi-redhat Done.