Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the hardware compatibility list #71

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

ptrnull
Copy link
Contributor

@ptrnull ptrnull commented Feb 19, 2021

Updating the quickstart document to have the compatible device list aligned with what is in the code and https://docs.openshift.com/container-platform/4.6/networking/hardware_networks/about-sriov.html#supported-devices_about-sriov

@ptrnull ptrnull requested a review from zshi-redhat February 19, 2021 14:03
@martinkennelly
Copy link
Member

martinkennelly commented Feb 19, 2021

Can you add Intel E810-CQDA2 and E810-XXVDA2 as well? It was added into this operators NIC map on a previous commit.

   Intel E810-CQDA2/2CQDA2 100 GbE dual-port QSFP28 | 8086  | 1592 
   Intel E810-XXVDA4 25 GbE quad-port SFP28 | 8086  | 1593 
   Intel E810-XXVDA2 25 GbE dual-port SFP28 | 8086  | 159b 

Thank you!

@ptrnull
Copy link
Contributor Author

ptrnull commented Feb 19, 2021

Can you add Intel E810-CQDA2 and E810-XXVDA2 as well? It was added into this operators NIC map on a previous commit.

   Intel E810-CQDA2/2CQDA2 100 GbE dual-port QSFP28 | 8086  | 1592 
   Intel E810-XXVDA4 25 GbE quad-port SFP28 | 8086  | 1593 
   Intel E810-XXVDA2 25 GbE dual-port SFP28 | 8086  | 159b 

Thank you!

Done!

@pliurh
Copy link
Collaborator

pliurh commented Mar 2, 2021

/lgtm

@github-actions github-actions bot added the lgtm label Mar 2, 2021
Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this ! it certainly helps understand better what is supported and what is not.

added a comment with suggested change.

@ptrnull ptrnull requested a review from adrianchiris March 2, 2021 10:38
@pliurh pliurh mentioned this pull request Mar 4, 2021
6 tasks
@ptrnull ptrnull requested a review from adrianchiris March 8, 2021 11:28
@adrianchiris
Copy link
Collaborator

@ptrnull mind squasing to a single commit with a descriptive commit message ?

…ligned with what is in the code and https://docs.openshift.com/container-platform/4.6/networking/hardware_networks/about-sriov.html#supported-devices_about-sriov

As @zshi-redhat  requested I'm adding the new supported Intel models:
| Intel E810-CQDA2/2CQDA2 100 GbE dual-port QSFP28 | 8086  | 1592 |
| Intel E810-XXVDA4 25 GbE quad-port SFP28 | 8086  | 1593 |
| Intel E810-XXVDA2 25 GbE dual-port SFP28 | 8086  | 159b |

Fixing the Intel Vendor and Device ID's and some cleaning to make sure its consistent.
@ptrnull
Copy link
Contributor Author

ptrnull commented Mar 8, 2021

@adrianchiris Done!

@adrianchiris adrianchiris merged commit be8e4ae into k8snetworkplumbingwg:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants