Daemon redesign - using controller-runtime #788
+1,433
−1,242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
SchSeba
force-pushed
the
daemon_redesign
branch
3 times, most recently
from
9f5207e to
7d4e946
Compare
SchSeba
force-pushed
the
daemon_redesign
branch
2 times, most recently
from
e17b584 to
ddc70f2
Compare
SchSeba
force-pushed
the
daemon_redesign
branch
2 times, most recently
from
929886d to
9377404
Compare
SchSeba
force-pushed
the
daemon_redesign
branch
4 times, most recently
from
79cc69b to
dc6eb11
Compare
Signed-off-by: Sebastian Sch <[email protected]>
Signed-off-by: Sebastian Sch <[email protected]>
Signed-off-by: Sebastian Sch <[email protected]>
Signed-off-by: Sebastian Sch <[email protected]>
Signed-off-by: Sebastian Sch <[email protected]>
Signed-off-by: Sebastian Sch <[email protected]>
Signed-off-by: Sebastian Sch <[email protected]>
Signed-off-by: Sebastian Sch <[email protected]>
It's only a one time run script so it should not be a problem to run with debug logs. Signed-off-by: Sebastian Sch <[email protected]>
some time the kernel is not fully loaded, and we see issues like ```` unbindDriver(): failed to unbind driver "error": "open /sys/bus/pci/drivers/igbvf/unbind: permission denied" ``` Signed-off-by: Sebastian Sch <[email protected]>
Signed-off-by: Sebastian Sch <[email protected]>
Signed-off-by: Sebastian Sch <[email protected]>
SchSeba
force-pushed
the
daemon_redesign
branch
from
dc6eb11 to
50ad79a
Compare
SchSeba
changed the title
| // Add retry here as some time the kernel is not fully loaded, and we see issues like | ||
| // unbindDriver(): failed to unbind driver "error": "open /sys/bus/pci/drivers/igbvf/unbind: permission denied" | ||
| i := 0 | ||
| for i < 5 { |
There was a problem hiding this comment.
can you move this change to a separate PR?
I think we should review discuss it separately.
There was a problem hiding this comment.
Was the problem that is described in the comment ever seen with this patch?#808 I think it can implicitly fix the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.