Add waitForDevicesInitialization to systemd service #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function ensures that the network devices specified in the configuration are registered and handled by UDEV. Sometimes, the initialization of network devices might take a significant amount of time, and the sriov-config systemd service may start before the devices are fully processed, leading to failure.
|
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
Pull Request Test Coverage Report for Build 11957819658Details
💛 - Coveralls |
zeeke
reviewed
Nov 25, 2024
| // The command watches the udev event queue, and exits if all current events are handled. | ||
| func (u *udev) WaitUdevEventsProcessed(timeout int) error { | ||
| log.Log.V(2).Info("WaitUdevEventsProcessed()") | ||
| _, stderr, err := u.utilsHelper.RunCommand("udevadm", "settle", "-t", strconv.Itoa(timeout)) |
There was a problem hiding this comment.
Is this supposed to run in the host chroot? I tried running it in the config-daemon pod:
[root@cnfdr22 /]# udevadm settle -t 10
Running in chroot, ignoring request.
There was a problem hiding this comment.
Currently this function will never run inside the daemon Pod. The function is executed by the sriov-config and sriov-config-post-networking systemd services on boot. When running as a part of systemd service the functions have direct access to the host's tools and there is no need to use chroot
There was a problem hiding this comment.
Got it, I wrongly thought the systemd service was running the config-daemon via podman run ... .
thanks for explaining
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add waitForDevicesInitialization to systemd service.
This function ensures that the network devices specified in the configuration are registered and handled by UDEV. Sometimes, the initialization of network devices might take a significant amount of time, and the sriov-config systemd service may start before the devices are fully processed, leading to failure.