[switchdev 9/9] Enable new switchdev implementation #643

ykulazhenkov · 2024-02-26T14:32:27Z

This PR contains multiple commits to disable and remove current switchdev implementation and to enable new one.

Depends on #628 and #642

This PR should be the last one in the series

cc @adrianchiris @zeeke @SchSeba

last 5 commits are relevant for the PR

github-actions · 2024-02-26T14:32:41Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-02-26T15:44:00Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

coveralls · 2024-02-26T15:48:51Z

Pull Request Test Coverage Report for Build 8373549591

Details

189 of 289 (65.4%) changed or added relevant lines in 9 files are covered.
24 unchanged lines in 8 files lost coverage.
Overall coverage increased (+0.7%) to 38.486%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/daemon/daemon.go	1	2	50.0%
pkg/plugins/generic/generic_plugin.go	0	1	0.0%
pkg/host/internal/udev/udev.go	36	40	90.0%
api/v1/helper.go	12	19	63.16%
pkg/plugins/k8s/k8s_plugin.go	73	85	85.88%
pkg/host/mock/mock_host.go	34	48	70.83%
pkg/host/internal/sriov/sriov.go	21	44	47.73%
pkg/helper/mock/mock_helper.go	10	48	20.83%

Files with Coverage Reduction	New Missed Lines	%
pkg/daemon/daemon.go	1	47.37%
pkg/host/internal/service/service.go	2	17.04%
pkg/client/clientset/versioned/typed/sriovnetwork/v1/fake/fake_sriovnetworknodestate.go	2	48.65%
pkg/host/internal/udev/udev.go	3	67.86%
api/v1/helper.go	3	46.92%
pkg/plugins/k8s/k8s_plugin.go	4	77.51%
pkg/host/internal/sriov/sriov.go	4	43.93%
pkg/helper/mock/mock_helper.go	5	20.67%

Totals
Change from base Build 8340797420:	0.7%
Covered Lines:	4855
Relevant Lines:	12615

💛 - Coveralls

bindata/scripts/switchdev-vf-link-name.sh

github-actions · 2024-02-27T14:25:09Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-02-27T17:41:50Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-02-27T17:53:23Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-02-28T07:36:59Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-03-05T10:37:05Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-03-05T11:52:49Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-03-08T12:23:50Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-03-12T07:09:11Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

SchSeba

partial review.
nice work one comment that is critical is the removed of the vfs to skip I didn't see any replacement for that functionallity

SchSeba · 2024-03-13T20:15:22Z

bindata/scripts/clean-k8s-services.sh

-# Restart system services
-chroot $chroot_path /bin/bash -c systemctl restart NetworkManager.service >/dev/null 2>&1 || true
-chroot $chroot_path /bin/bash -c systemctl restart ovs-vswitchd.service >/dev/null 2>&1 || true
+fi


we do not release ovs and network manager anymore on cleanup?

We don't patch NetworkManager anymore so there is no need to reload it. Restart of the ovs was always useless, because it doesn't not change anything (hw-offloading option is stored in ovsdb and will be preserved after restart)

SchSeba · 2024-03-13T20:30:26Z

pkg/host/internal/udev/udev.go

+		log.Log.Error(err, "PrepareVFRepUdevRule(): failed to write representor name UDEV script")
+		return err
+	}
+	if err := os.Chmod(targetPath, 0755); err != nil {


if we write the file with that permission should we also change the permissions?

Permissions from WriteFile function are used for new files only. We need to hanlde scenario with exisiting file as well.

this file may be written with permissions other than 755? or you want to handle a case where the file's permissions somehow changed ?

this file may be written with permissions other than 755? or you want to handle a case where the file's permissions somehow changed ?

Yes, to handle permission change. I'm fine to remove this call if you both think that this is not needed.

im fine with either :)

SchSeba · 2024-03-13T20:34:23Z

pkg/plugins/generic/generic_plugin.go

-}
-
-// skipConfigVf Use systemd service to configure switchdev mode or BF-2 NICs in OpenShift
-func skipConfigVf(ifSpec sriovnetworkv1.Interface, ifStatus sriovnetworkv1.InterfaceExt, mlxHelper mlx.MellanoxInterface) (bool, error) {


how we handle the BF cards if we remove this one?

I assume there is no need for special handling of BF cards anymore. Creation of VFs should work in both BF modes(DPU and NIC) when the operator is in any configuration mode(in daemon or in systemd mode). If you need to create VFs on boot, e.g. for hw-offloading use-case, you need to switch the operator to systemd mode.

Did I miss something?

we are running some validations internally base on OCP deployment and BF2 just to be sure everything continue to work as expected

cc @zeeke

pkg/plugins/k8s/k8s_plugin.go

adrianchiris

Great work @ykulazhenkov went over the PR added some nits.
Overall LGTM from my side.

any idea why k8s CI is failing ?

SchSeba · 2024-03-18T10:11:00Z

Hi @ykulazhenkov will you be able to rebase this PR please :)

Signed-off-by: Yury Kulazhenkov <[email protected]>

Additional checks to perform: - Eswitch mode - VdpaType for VFs Signed-off-by: Yury Kulazhenkov <[email protected]>

PrepareVFRepUdevRule() function creates helper scrip for udev rules that rename VF representors in switchdev mode. Signed-off-by: Yury Kulazhenkov <[email protected]>

This commit removes services and scripts related to old switchdev implementations Signed-off-by: Yury Kulazhenkov <[email protected]>

github-actions · 2024-03-18T11:59:44Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

ykulazhenkov · 2024-03-18T12:00:24Z

Hi @ykulazhenkov will you be able to rebase this PR please :)

@SchSeba
done, thx

github-actions · 2024-03-20T15:08:58Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

Signed-off-by: Yury Kulazhenkov <[email protected]>

Fix the function to correctly handle devices which doesn't support software_steering Signed-off-by: Yury Kulazhenkov <[email protected]>

github-actions · 2024-03-20T18:49:52Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-03-21T09:54:08Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-03-21T10:07:46Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-03-21T10:36:48Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

The operator will create two rules specific for PFs in swithcdev mode: - rule to persist PF name after switching to switchdev mode - rule to rename VF representors First rule can be applied before PF is switched to switchdev mode. Second rule can be applied only when the PF is already in switchdev mode(phys_port_name and phys_switch_id) may not be available when PF is in legacy mode. reload of UDEV rules is required to apply VF representor rule for already created VFs. Signed-off-by: Yury Kulazhenkov <[email protected]>

github-actions · 2024-03-21T10:37:19Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

e0ne

Glad to see bash scripts removal!

zeeke

No regression has been showed against OpenShift/OVNk Hardware Offloading scenario

LGTM

ykulazhenkov marked this pull request as draft February 26, 2024 14:37

ykulazhenkov force-pushed the pr-turn-on-switchdev branch from 92b5cea to 72cbc06 Compare February 26, 2024 15:43

ykulazhenkov marked this pull request as ready for review February 26, 2024 16:46

e0ne reviewed Feb 27, 2024

View reviewed changes

bindata/scripts/switchdev-vf-link-name.sh Outdated Show resolved Hide resolved

ykulazhenkov force-pushed the pr-turn-on-switchdev branch from 72cbc06 to ca23af7 Compare February 27, 2024 14:24

ykulazhenkov force-pushed the pr-turn-on-switchdev branch from ca23af7 to 168086e Compare February 27, 2024 17:41

ykulazhenkov force-pushed the pr-turn-on-switchdev branch from 168086e to 6f63b38 Compare February 27, 2024 17:53

ykulazhenkov force-pushed the pr-turn-on-switchdev branch from 6f63b38 to 4157e8f Compare February 28, 2024 07:36

ykulazhenkov force-pushed the pr-turn-on-switchdev branch from 4157e8f to a271d5a Compare March 5, 2024 10:36

ykulazhenkov closed this Mar 5, 2024

ykulazhenkov reopened this Mar 5, 2024

ykulazhenkov closed this Mar 8, 2024

ykulazhenkov reopened this Mar 8, 2024

SchSeba mentioned this pull request Mar 10, 2024

Add "Software bridge management" design doc #640

Merged

ykulazhenkov force-pushed the pr-turn-on-switchdev branch from a271d5a to f5678a8 Compare March 12, 2024 07:08

SchSeba reviewed Mar 13, 2024

View reviewed changes

adrianchiris reviewed Mar 14, 2024

View reviewed changes

pkg/plugins/k8s/k8s_plugin.go Show resolved Hide resolved

adrianchiris reviewed Mar 14, 2024

View reviewed changes

pkg/plugins/k8s/k8s_plugin.go Show resolved Hide resolved

adrianchiris reviewed Mar 14, 2024

View reviewed changes

adrianchiris approved these changes Mar 14, 2024

View reviewed changes

ykulazhenkov added 4 commits March 18, 2024 13:46

Update sriov.GetVfInfo to report VDPA type

61d780a

Signed-off-by: Yury Kulazhenkov <[email protected]>

Add switchdev-related checks to api.v1.NeedToUpdateSriov function

253edc8

Additional checks to perform: - Eswitch mode - VdpaType for VFs Signed-off-by: Yury Kulazhenkov <[email protected]>

Create VF representor udev script in the daemon.go

309a38d

PrepareVFRepUdevRule() function creates helper scrip for udev rules that rename VF representors in switchdev mode. Signed-off-by: Yury Kulazhenkov <[email protected]>

Remove deployment of old switchdev implementation

18a93cf

This commit removes services and scripts related to old switchdev implementations Signed-off-by: Yury Kulazhenkov <[email protected]>

ykulazhenkov force-pushed the pr-turn-on-switchdev branch from f5678a8 to ca9cc92 Compare March 18, 2024 11:59

ykulazhenkov added 2 commits March 20, 2024 20:07

Remove old switchdev implementation

f296db7

Signed-off-by: Yury Kulazhenkov <[email protected]>

Fix sriov.configureHWOptionsForSwitchdev function

68ef448

Fix the function to correctly handle devices which doesn't support software_steering Signed-off-by: Yury Kulazhenkov <[email protected]>

ykulazhenkov force-pushed the pr-turn-on-switchdev branch from e0bfa73 to b7fb8ce Compare March 20, 2024 18:49

ykulazhenkov force-pushed the pr-turn-on-switchdev branch from b7fb8ce to 9cdd37c Compare March 21, 2024 09:53

ykulazhenkov force-pushed the pr-turn-on-switchdev branch from 9cdd37c to c5a086f Compare March 21, 2024 10:07

ykulazhenkov force-pushed the pr-turn-on-switchdev branch from c5a086f to b40c9ba Compare March 21, 2024 10:36

ykulazhenkov force-pushed the pr-turn-on-switchdev branch from b40c9ba to 0bdf464 Compare March 21, 2024 10:37

e0ne approved these changes Mar 25, 2024

View reviewed changes

midnattsol mentioned this pull request Mar 27, 2024

[StatefulSet/Parallel] Virtual Functions Issues When Creating/Destroying Pods in Parallel. Switching devices #668

Open

zeeke approved these changes Mar 28, 2024

View reviewed changes

zeeke merged commit 160d177 into k8snetworkplumbingwg:master Mar 28, 2024
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[switchdev 9/9] Enable new switchdev implementation #643

[switchdev 9/9] Enable new switchdev implementation #643

ykulazhenkov commented Feb 26, 2024 •

edited

Loading

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

coveralls commented Feb 26, 2024 •

edited

Loading

github-actions bot commented Feb 27, 2024

github-actions bot commented Feb 27, 2024

github-actions bot commented Feb 27, 2024

github-actions bot commented Feb 28, 2024

github-actions bot commented Mar 5, 2024

github-actions bot commented Mar 5, 2024

github-actions bot commented Mar 8, 2024

github-actions bot commented Mar 12, 2024

SchSeba left a comment

SchSeba Mar 13, 2024

ykulazhenkov Mar 14, 2024

SchSeba Mar 13, 2024

ykulazhenkov Mar 14, 2024

adrianchiris Mar 14, 2024

ykulazhenkov Mar 14, 2024

adrianchiris Mar 14, 2024

SchSeba Mar 13, 2024

ykulazhenkov Mar 14, 2024 •

edited

Loading

SchSeba Mar 18, 2024

adrianchiris left a comment •

edited

Loading

SchSeba commented Mar 18, 2024

github-actions bot commented Mar 18, 2024

ykulazhenkov commented Mar 18, 2024 •

edited

Loading

github-actions bot commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

github-actions bot commented Mar 21, 2024

github-actions bot commented Mar 21, 2024

github-actions bot commented Mar 21, 2024

github-actions bot commented Mar 21, 2024

e0ne left a comment

zeeke left a comment

[switchdev 9/9] Enable new switchdev implementation #643

[switchdev 9/9] Enable new switchdev implementation #643

Conversation

ykulazhenkov commented Feb 26, 2024 • edited Loading

github-actions bot commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

coveralls commented Feb 26, 2024 • edited Loading

Pull Request Test Coverage Report for Build 8373549591

Details

💛 - Coveralls

github-actions bot commented Feb 27, 2024

github-actions bot commented Feb 27, 2024

github-actions bot commented Feb 27, 2024

github-actions bot commented Feb 28, 2024

github-actions bot commented Mar 5, 2024

github-actions bot commented Mar 5, 2024

github-actions bot commented Mar 8, 2024

github-actions bot commented Mar 12, 2024

SchSeba left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ykulazhenkov Mar 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adrianchiris left a comment • edited Loading

Choose a reason for hiding this comment

SchSeba commented Mar 18, 2024

github-actions bot commented Mar 18, 2024

ykulazhenkov commented Mar 18, 2024 • edited Loading

github-actions bot commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

github-actions bot commented Mar 21, 2024

github-actions bot commented Mar 21, 2024

github-actions bot commented Mar 21, 2024

github-actions bot commented Mar 21, 2024

e0ne left a comment

Choose a reason for hiding this comment

zeeke left a comment

Choose a reason for hiding this comment

ykulazhenkov commented Feb 26, 2024 •

edited

Loading

coveralls commented Feb 26, 2024 •

edited

Loading

ykulazhenkov Mar 14, 2024 •

edited

Loading

adrianchiris left a comment •

edited

Loading

ykulazhenkov commented Mar 18, 2024 •

edited

Loading