[switchdev 7/x] Add function EnableHwTcOffload to the network pkg #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 8051307951Details
💛 - Coveralls |
ykulazhenkov
changed the title
ykulazhenkov
force-pushed
the
pr-enable-hw-tc-offload
branch
from
c87a5f9 to
5c9c6fa
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
e0ne
requested changes
Feb 22, 2024
ykulazhenkov
force-pushed
the
pr-enable-hw-tc-offload
branch
from
5c9c6fa to
7861d5b
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
ykulazhenkov
force-pushed
the
pr-enable-hw-tc-offload
branch
from
7861d5b to
a20d5e5
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
ykulazhenkov
force-pushed
the
pr-enable-hw-tc-offload
branch
from
a20d5e5 to
eb2cc96
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
ykulazhenkov
force-pushed
the
pr-enable-hw-tc-offload
branch
from
eb2cc96 to
d00c856
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
e0ne
approved these changes
Feb 26, 2024
zeeke
reviewed
Feb 26, 2024
pkg/host/internal/network/network.go
Outdated
| return err | ||
| } | ||
| if _, isKnown := knownFeatures[hwTcOffloadFeatureName]; !isKnown { | ||
| log.Log.V(2).Info("EnableHwTcOffload(): can't enable feature, feature is not supported", "device", ifaceName) |
There was a problem hiding this comment.
I think this can log with V(0), or it can even return an error.
It really depends on how you're going to use this function, but if the user set a flag somewhere to enable HwTcOffload, it is expected to work or to get an error somewhere. WDYT?
Same for L329
There was a problem hiding this comment.
agree, I fixed the log level
This function ensures that hw-tc-offload feature is enabled for the interface if the interface supports it. relies on github.com/safchain/ethtool lib Signed-off-by: Yury Kulazhenkov <[email protected]>
ykulazhenkov
force-pushed
the
pr-enable-hw-tc-offload
branch
from
d00c856 to
154a9ed
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function ensures that hw-tc-offload feature is enabled for the interface if the interface supports it.
required to be compatible with the current switchdev implementation
uses
github.com/safchain/ethtoollibcc @adrianchiris @SchSeba @zeeke
depends on #633
only last commit to review