Validate .Spec.DisableDrain #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
force-pushed
the
validate-disable-drain
branch
from
3715423 to
9096080
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
zeeke
force-pushed
the
validate-disable-drain
branch
from
9096080 to
a40aa44
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 5452582694
💛 - Coveralls |
zeeke
force-pushed
the
validate-disable-drain
branch
from
a40aa44 to
c262772
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
adrianchiris
reviewed
Jul 4, 2023
Early exit from the function to make the validation logic more evident and allow further improvements. Signed-off-by: Andrea Panattoni <[email protected]>
Disable the drain while a node is updating its configuration prevents the config-daemon to uncordon the node, leading to a node that needs to be manually uncordoned. Signed-off-by: Andrea Panattoni <[email protected]>
zeeke
force-pushed
the
validate-disable-drain
branch
from
c262772 to
91ea65f
Compare
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
adrianchiris
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a webhook validation for the
SriovOperatorConfigto avoid disabling the drain whilethe config-daemon is updating a node. Disabling the drain at this stage would prevent the operator to uncordon a node at the end of the update operation, keeping nodes un-schedulable until manual intervention.
Introduce a small refactor of
validateSriovOperatorConfig(...)this PR needs
cc @mlguerrero12