Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sriovoperatorconfigs resource to webhook #461

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Add sriovoperatorconfigs resource to webhook #461

merged 2 commits into from
Jul 3, 2023

Conversation

mlguerrero12
Copy link
Contributor

The sriovoperatorconfigs resource was not present in the validating webhook configuration. The logic to validate this object was not triggered.

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@zeeke zeeke mentioned this pull request Jun 28, 2023
Merged
@mlguerrero12
Copy link
Contributor Author

/test-all

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@mlguerrero12
Add sriovoperatorconfigs resource to webhook
a6d499e 
The sriovoperatorconfigs resource was not present in the
validating webhook configuration. The logic to validate this object
was not triggered.

Signed-off-by: Marcelo Guerrero <[email protected]>
@mlguerrero12
Disable webhooks in api server of envtest
9262126 
The operatorconfig controller tests were broken due to
the validating webhook.

Signed-off-by: Marcelo Guerrero <[email protected]>
@mlguerrero12 mlguerrero12 force-pushed the addoperatorconfigwebhook branch from e68c666 to 9262126 Compare July 1, 2023 00:04
@github-actions
Copy link

github-actions bot commented Jul 1, 2023

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5427979143

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.05%) to 25.82%
Files with Coverage Reduction New Missed Lines %
controllers/sriovnetwork_controller.go 2 65.71%
api/v1/helper.go 3 41.92%
controllers/sriovibnetwork_controller.go 4 64.15%
Totals Coverage Status
Change from base Build 5409975458: -0.05%
Covered Lines: 1961
Relevant Lines: 7595
💛 - Coveralls

zeeke
zeeke approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlguerrero12 Thanks for fixing this

@mlguerrero12
Copy link
Contributor Author

@adrianchiris, @Eoghan1232, could you please have a look at this? Needed by #464

Eoghan1232
Eoghan1232 reviewed Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@Eoghan1232 Eoghan1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

SchSeba
SchSeba approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchSeba
Copy link
Collaborator

SchSeba commented Jul 3, 2023

approved by two maintainers from different companies. merging

@SchSeba SchSeba merged commit 2d37483 into k8snetworkplumbingwg:master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eoghan1232 Eoghan1232 Eoghan1232 approved these changes

@SchSeba SchSeba SchSeba approved these changes

@zeeke zeeke zeeke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mlguerrero12 @coveralls @SchSeba @zeeke @Eoghan1232