Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove go get <binary> instances #348

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Remove go get <binary> instances #348

merged 1 commit into from
Aug 11, 2022

Conversation

zeeke
Copy link
Member

@zeeke zeeke commented Aug 4, 2022

Go getting bninaries has been deprecated in go1.17 and not supported
in go1.18.

Signed-off-by: Andrea Panattoni [email protected]

@zeeke
Remove go get <binary> instances
ad9bc39 
Go getting bninaries has been deprecated in go1.17 and not supported
in go1.18.

Signed-off-by: Andrea Panattoni <[email protected]>
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@zeeke zeeke mentioned this pull request Aug 4, 2022
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2796826855

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 15.585%
Files with Coverage Reduction New Missed Lines %
controllers/sriovibnetwork_controller.go 2 65.35%
controllers/sriovnetwork_controller.go 4 67.0%
api/v1/helper.go 6 34.2%
Totals Coverage Status
Change from base Build 2782055009: -0.2%
Covered Lines: 1145
Relevant Lines: 7347
💛 - Coveralls

@rollandf
Copy link
Contributor

rollandf commented Aug 9, 2022

LGTM

SchSeba
SchSeba approved these changes Aug 11, 2022
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@e0ne e0ne merged commit ca051bc into k8snetworkplumbingwg:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchSeba SchSeba SchSeba approved these changes

@e0ne e0ne e0ne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zeeke @coveralls @rollandf @e0ne @SchSeba