Skip to content

Commit

Permalink
Merge pull request #348 from zeeke/ginkgo-go-install
Browse files Browse the repository at this point in the history
Remove `go get <binary>` instances
  • Loading branch information
e0ne authored Aug 11, 2022
2 parents 181d1b9 + ad9bc39 commit ca051bc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ ENVTEST = $(shell pwd)/bin/setup-envtest
envtest: ## Download envtest-setup locally if necessary.
$(call go-get-tool,$(ENVTEST),sigs.k8s.io/controller-runtime/tools/setup-envtest@latest)

# go-get-tool will 'go get' any package $2 and install it to $1.
# go-get-tool will 'go install' any package $2 and install it to $1.
PROJECT_DIR := $(shell dirname $(abspath $(lastword $(MAKEFILE_LIST))))
define go-get-tool
@[ -f $(1) ] || { \
Expand Down
2 changes: 1 addition & 1 deletion hack/run-e2e-conformance.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ if [ $? -ne 0 ]; then
GINKGO_TMP_DIR=$(mktemp -d)
cd $GINKGO_TMP_DIR
go mod init tmp
go get github.com/onsi/ginkgo/ginkgo@v1.12.0
go install github.com/onsi/ginkgo/ginkgo@v1.16.5
rm -rf $GINKGO_TMP_DIR
echo "Downloading ginkgo tool"
cd -
Expand Down

0 comments on commit ca051bc

Please sign in to comment.