-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to golang 1.18 #310
Bump to golang 1.18 #310
Conversation
Thanks for your PR,
To skip the vendors CIs use one of:
|
LGTM |
.github/workflows/go.yml
Outdated
uses: actions/setup-go@v2 | ||
with: | ||
go-version: 1.17.8 | ||
go-version: 1.18.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to specify exact version here and just 1.18 in Dockerfile? IMO, it's enough to set 1.18 everywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alternative is to use : '>=1.18.2'
if we bump to actions/setup-go@v3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change it to v3 and use 1.18.2 I was like to be specific that it must be >= 1.18.2
a1fa0cc
to
4225d2d
Compare
Thanks for your PR,
To skip the vendors CIs use one of:
|
Signed-off-by: Sebastian Sch <[email protected]>
Signed-off-by: Sebastian Sch <[email protected]>
4225d2d
to
d106b90
Compare
Thanks for your PR,
To skip the vendors CIs use one of:
|
fixing also the kustomize using the newer version before the change
after the change
|
No description provided.