Add coverage evidence to the project #281

zeeke · 2022-04-07T12:20:52Z

In order to increase project quality, it would be useful to monitor unit test code coverage and try to not decrease it with PRs.
Besides this commit, an admin is needed to link the repository to https://coveralls.io/ to enable it.

Configure CI to collect coverage and integrate with coveralls.io
service.

Move plugin packages out of pkg package, as they aren't
exportable as library and their presence conflicts with
-coverpkg=./... cover parameter.

Add Makefile rules for merging coverage profiles from multiple
sources, as tests are usually run by make test-pkg and
make test-controllers.

Signed-off-by: Andrea Panattoni [email protected]

github-actions · 2022-04-07T12:21:07Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

e0ne

LGTM, thanks for this improvement

github-actions · 2022-04-14T15:28:31Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2022-04-21T12:07:45Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2022-04-27T08:59:06Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2022-04-27T09:04:58Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

SchSeba · 2022-05-17T09:51:03Z

Hi @zeeke can you please rebase this PR?

github-actions · 2022-05-17T10:18:29Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

Makefile

github-actions · 2022-06-01T10:30:43Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

SchSeba · 2022-06-06T15:07:22Z

Hi @zeeke we have this PR (#312) will you be able to leave the plugins under the pkg folder. after that PR they will be just part of the code.

also please change the version to 1.18 like in this PR #310

zeeke · 2022-06-06T15:15:00Z

I needed to move the plugin package because the -coverpkg ./... parameter was triggering k8s.init() function and I got panics during tests. I prefer to wait for #312 to be merged and then resolve related conflicts, they should be a trivial accept

e0ne

Why do we need to move plugins to another directory? How this will work with PR #312

zeeke · 2022-06-23T09:13:12Z

Because the -coverpkg ./... parameter triggers the pkg/plugins/k8s init() function, causing a panic during test run.
#312 gets rid of that panic, so if it gets merged before this, I'll be happy to rebase and keep plugins package under pkg.

I can mark this PR as a draft and wait for #312 to be in.

adrianchiris · 2022-06-30T06:04:44Z

Hi @zeeke now that PR#312 was merged, we can proceed with this one !

github-actions · 2022-06-30T08:44:04Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

Configure CI to collect coverage and integrate with coveralls.io service. Add Makefile rules for merging coverage profiles from multiple sources, as tests are usually run by `make test-pkg` and `make test-controllers`. Add Makefile's rules to download gocovmerge and gcov2lcov. Signed-off-by: Andrea Panattoni <[email protected]>

github-actions · 2022-06-30T13:00:46Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

rollandf · 2022-07-13T09:00:34Z

LGTM

adrianchiris

LGTM. @SchSeba can we merge this one ?

Eoghan1232 · 2022-07-18T14:52:49Z

LGTM

e0ne approved these changes Apr 8, 2022

View reviewed changes

zeeke force-pushed the coveralls branch from 78d6185 to 367532a Compare April 14, 2022 15:28

zeeke force-pushed the coveralls branch from 367532a to 2d83051 Compare April 21, 2022 12:07

zeeke force-pushed the coveralls branch from 2d83051 to 5b9a69a Compare April 27, 2022 08:58

zeeke force-pushed the coveralls branch from 5b9a69a to 2254a8d Compare April 27, 2022 09:04

zeeke force-pushed the coveralls branch from 2254a8d to 85a2bb8 Compare May 17, 2022 10:18

adrianchiris reviewed Jun 1, 2022

View reviewed changes

Makefile Outdated Show resolved Hide resolved

zeeke force-pushed the coveralls branch from 85a2bb8 to 61cc74f Compare June 1, 2022 10:30

adrianchiris approved these changes Jun 1, 2022

View reviewed changes

e0ne requested changes Jun 23, 2022

View reviewed changes

zeeke force-pushed the coveralls branch from 61cc74f to 48fac4d Compare June 30, 2022 08:43

zeeke force-pushed the coveralls branch from 48fac4d to bcab884 Compare June 30, 2022 13:00

adrianchiris approved these changes Jul 14, 2022

View reviewed changes

Eoghan1232 approved these changes Jul 18, 2022

View reviewed changes

Eoghan1232 merged commit eec7f41 into k8snetworkplumbingwg:master Jul 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add coverage evidence to the project #281

Add coverage evidence to the project #281

zeeke commented Apr 7, 2022

github-actions bot commented Apr 7, 2022

e0ne left a comment

github-actions bot commented Apr 14, 2022

github-actions bot commented Apr 21, 2022

github-actions bot commented Apr 27, 2022

github-actions bot commented Apr 27, 2022

SchSeba commented May 17, 2022

github-actions bot commented May 17, 2022

github-actions bot commented Jun 1, 2022

SchSeba commented Jun 6, 2022

zeeke commented Jun 6, 2022

e0ne left a comment

zeeke commented Jun 23, 2022

adrianchiris commented Jun 30, 2022

github-actions bot commented Jun 30, 2022

github-actions bot commented Jun 30, 2022

rollandf commented Jul 13, 2022

adrianchiris left a comment

Eoghan1232 commented Jul 18, 2022

Add coverage evidence to the project #281

Add coverage evidence to the project #281

Conversation

zeeke commented Apr 7, 2022

github-actions bot commented Apr 7, 2022

e0ne left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 14, 2022

github-actions bot commented Apr 21, 2022

github-actions bot commented Apr 27, 2022

github-actions bot commented Apr 27, 2022

SchSeba commented May 17, 2022

github-actions bot commented May 17, 2022

github-actions bot commented Jun 1, 2022

SchSeba commented Jun 6, 2022

zeeke commented Jun 6, 2022

e0ne left a comment

Choose a reason for hiding this comment

zeeke commented Jun 23, 2022

adrianchiris commented Jun 30, 2022

github-actions bot commented Jun 30, 2022

github-actions bot commented Jun 30, 2022

rollandf commented Jul 13, 2022

adrianchiris left a comment

Choose a reason for hiding this comment

Eoghan1232 commented Jul 18, 2022