Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add Marvell FastLinQ QL45000 Series QLogic Corp #263

Merged
merged 9 commits into from
Mar 14, 2022
Merged

Request to add Marvell FastLinQ QL45000 Series QLogic Corp #263

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1865420
Request to add Marvell FastLinQ QL45000 Series QLogic Corp
Mar 8, 2022
c5713c5
Updated Readme and Yaml
Mar 14, 2022
094dac8
working around the Space and new line
Mar 14, 2022
0e9cf21
another attempt
Mar 14, 2022
92e2e31
3rd attempt
Mar 14, 2022
2ddc818
4th ateempt
Mar 14, 2022
7636646
testing
Mar 14, 2022
13cb147
Update configmap.yaml
Eoghan1232 Mar 14, 2022
23008fc
Update configmap.yaml
Eoghan1232 Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions deploy/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,4 @@ data:
Nvidia_mlx5_MT42822_BlueField-2_integrated_ConnectX-6_Dx: "15b3 a2d6 101e"
Broadcom_bnxt_BCM57414_2x25G: "14e4 16d7 16dc"
Broadcom_bnxt_BCM75508_2x100G: "14e4 1750 1806"
Qlogic_qede_QL45000_50G: "1077 1654 1664"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add newline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added new line /n

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
no matter what i do error remains

1 change: 1 addition & 0 deletions deployment/sriov-network-operator/templates/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,4 @@ data:
Nvidia_mlx5_MT42822_BlueField-2_integrated_ConnectX-6_Dx: "15b3 a2d6 101e"
Broadcom_bnxt_BCM57414_2x25G: "14e4 16d7 16dc"
Broadcom_bnxt_BCM75508_2x100G: "14e4 1750 1806"
Qlogic_qede_QL45000_50G: "1077 1654 1664"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add newline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added new line /n

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
no matter what i do error remains

3 changes: 2 additions & 1 deletion doc/quickstart.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
| Mellanox MT28908 Family [ConnectX-6] | 15b3 | 101b |
| Mellanox MT28908 Family [ConnectX-6 Dx] | 15b3 | 101d |
| Mellanox MT42822 BlueField-2 integrated ConnectX-6 Dx | 15b3 | a2d6 |

| Qlogic QL45000 Series Gigabit Ethernet Controller | 1077 | 1664 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so are you adding two types of NICs ?

vendor ID : 1077 , device ID 1664
vendor ID: 1077 , device ID 1654

according to the configMaps above , the PF (physical function) device ID is 1654, and the VF (Virtual function) device ID is 1664

if this is the case, then you need just one line here containing the PF information only.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed VF ID in readme

| Qlogic QL45000 Series 50GbE Controller | 1077 | 1654 |

2. Kubernetes or Openshift cluster running on bare metal nodes.
3. Multus-cni is deployed as default CNI plugin, and there is a default CNI plugin (flannel, openshift-sdn etc.) available for Multus-cni.
Expand Down