-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request to add Marvell FastLinQ QL45000 Series QLogic Corp #263
Request to add Marvell FastLinQ QL45000 Series QLogic Corp #263
Conversation
Thanks for your PR,
To skip the vendors CIs use one of:
|
deploy/configmap.yaml
Outdated
@@ -20,3 +20,4 @@ data: | |||
Nvidia_mlx5_MT42822_BlueField-2_integrated_ConnectX-6_Dx: "15b3 a2d6 101e" | |||
Broadcom_bnxt_BCM57414_2x25G: "14e4 16d7 16dc" | |||
Broadcom_bnxt_BCM75508_2x100G: "14e4 1750 1806" | |||
Qlogic_qede_QL45000_50G: "1077 1654 1664" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added new line /n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -20,3 +20,4 @@ data: | |||
Nvidia_mlx5_MT42822_BlueField-2_integrated_ConnectX-6_Dx: "15b3 a2d6 101e" | |||
Broadcom_bnxt_BCM57414_2x25G: "14e4 16d7 16dc" | |||
Broadcom_bnxt_BCM75508_2x100G: "14e4 1750 1806" | |||
Qlogic_qede_QL45000_50G: "1077 1654 1664" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added new line /n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc/quickstart.md
Outdated
@@ -17,7 +17,8 @@ | |||
| Mellanox MT28908 Family [ConnectX-6] | 15b3 | 101b | | |||
| Mellanox MT28908 Family [ConnectX-6 Dx] | 15b3 | 101d | | |||
| Mellanox MT42822 BlueField-2 integrated ConnectX-6 Dx | 15b3 | a2d6 | | |||
|
|||
| Qlogic QL45000 Series Gigabit Ethernet Controller | 1077 | 1664 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so are you adding two types of NICs ?
vendor ID : 1077 , device ID 1664
vendor ID: 1077 , device ID 1654
according to the configMaps above , the PF (physical function) device ID is 1654, and the VF (Virtual function) device ID is 1664
if this is the case, then you need just one line here containing the PF information only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed VF ID in readme
Updated Readme and Yaml as per Adrian's request
Thanks for your PR,
To skip the vendors CIs use one of:
|
deploy/configmap.yaml
Outdated
Qlogic_qede_QL45000_50G: "1077 1654 1664" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i still see github complaining here :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any thoughts I have tried multiple combination error still remains ?
https://user-images.githubusercontent.com/55138250/158124068-a51f6746-e9fd-4631-a166-64b5dcea3136.png
Qlogic_qede_QL45000_50G: "1077 1654 1664" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any thoughts I have tried multiple combination error still remains ?
https://user-images.githubusercontent.com/55138250/158124068-a51f6746-e9fd-4631-a166-64b5dcea3136.png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets sort out the newline issue, and im LGTM
working around the Space and new line https://user-images.githubusercontent.com/55138250/158124068-a51f6746-e9fd-4631-a166-64b5dcea3136.png both error out
Thanks for your PR,
To skip the vendors CIs use one of:
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
trying with spaces
Thanks for your PR,
To skip the vendors CIs use one of:
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
I fixed the issue with newline. LGTM |
Looks good Thanks Russell |
…#263) Update Readme and Yamls with device information Co-authored-by: Edwin Joseph <[email protected]> Co-authored-by: Eoghan Russell <[email protected]>
Add HPE Synergy 6820C 25/50Gb Converged Network Adapter - Marvell FastLinQ QL45000
Please refer to the issue
#234