Sync latest CRDs to helm chart #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshe010
approved these changes
Jul 24, 2021
e0ne
added a commit
to e0ne/network-operator
that referenced
this pull request
Jul 27, 2021
We can't use SR-IOV Network Operator chart from the official repo until k8snetworkplumbingwg/sriov-network-operator#167 will be merged and new chart will be punlished. This patch syncs the latest changes from the upstrem to Network Operator repo to deploy the lates version of the SR-IOV Network Operator.
e0ne
added a commit
to e0ne/network-operator
that referenced
this pull request
Jul 27, 2021
We can't use SR-IOV Network Operator chart from the official repo until k8snetworkplumbingwg/sriov-network-operator#167 will be merged and new chart will be punlished. This patch syncs the latest changes from the upstrem to Network Operator repo to deploy the lates version of the SR-IOV Network Operator. Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
| @@ -0,0 +1,41 @@ | |||
| # permissions to do leader election. | |||
There was a problem hiding this comment.
i dont think this is used today when running make deploy-k8s
IMO you need to update the role.yaml template
sriov-network-operator/deploy/role.yaml
Line 86 in 348e699
perhaps other .yaml files from deploy folder are out of sync
There was a problem hiding this comment.
Good catch, I'll update my PR with it
e0ne
added a commit
to e0ne/network-operator
that referenced
this pull request
Jul 28, 2021
We can't use SR-IOV Network Operator chart from the official repo until k8snetworkplumbingwg/sriov-network-operator#167 will be merged and new chart will be punlished. This patch syncs the latest changes from the upstrem to Network Operator repo to deploy the lates version of the SR-IOV Network Operator. Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
e0ne
added a commit
to e0ne/network-operator
that referenced
this pull request
Jul 28, 2021
We can't use SR-IOV Network Operator chart from the official repo until k8snetworkplumbingwg/sriov-network-operator#167 will be merged and new chart will be punlished. This patch syncs the latest changes from the upstrem to Network Operator repo to deploy the lates version of the SR-IOV Network Operator. Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
e0ne
added a commit
to e0ne/network-operator
that referenced
this pull request
Jul 28, 2021
We can't use SR-IOV Network Operator chart from the official repo until k8snetworkplumbingwg/sriov-network-operator#167 will be merged and new chart will be punlished. This patch syncs the latest changes from the upstrem to Network Operator repo to deploy the lates version of the SR-IOV Network Operator. Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
e0ne
added a commit
to e0ne/network-operator
that referenced
this pull request
Jul 28, 2021
We can't use SR-IOV Network Operator chart from the official repo until k8snetworkplumbingwg/sriov-network-operator#167 will be merged and new chart will be punlished. This patch syncs the latest changes from the upstrem to Network Operator repo to deploy the lates version of the SR-IOV Network Operator. Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
e0ne
added a commit
to e0ne/network-operator
that referenced
this pull request
Jul 28, 2021
We can't use SR-IOV Network Operator chart from the official repo until k8snetworkplumbingwg/sriov-network-operator#167 will be merged and new chart will be punlished. This patch syncs the latest changes from the upstrem to Network Operator repo to deploy the lates version of the SR-IOV Network Operator. Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
e0ne
added a commit
to e0ne/network-operator
that referenced
this pull request
Jul 28, 2021
We can't use SR-IOV Network Operator chart from the official repo until k8snetworkplumbingwg/sriov-network-operator#167 will be merged and new chart will be punlished. This patch syncs the latest changes from the upstrem to Network Operator repo to deploy the lates version of the SR-IOV Network Operator. Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
e0ne
added a commit
to e0ne/network-operator
that referenced
this pull request
Jul 29, 2021
We can't use SR-IOV Network Operator chart from the official repo until k8snetworkplumbingwg/sriov-network-operator#167 will be merged and new chart will be punlished. This patch syncs the latest changes from the upstrem to Network Operator repo to deploy the lates version of the SR-IOV Network Operator. Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
e0ne
added a commit
to e0ne/network-operator
that referenced
this pull request
Aug 1, 2021
We can't use SR-IOV Network Operator chart from the official repo until k8snetworkplumbingwg/sriov-network-operator#167 will be merged and new chart will be punlished. This patch syncs the latest changes from the upstrem to Network Operator repo to deploy the lates version of the SR-IOV Network Operator. Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
|
@pliurh @zshi-redhat can this be merged ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.