Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream SR-IOV Network Operator chart #221

Merged
merged 3 commits into from
Aug 3, 2021

Conversation

e0ne
Copy link
Collaborator

@e0ne e0ne commented Jul 23, 2021

No description provided.

@e0ne e0ne marked this pull request as draft July 23, 2021 15:33
@e0ne
Copy link
Collaborator Author

e0ne commented Jul 23, 2021

We need to wait for k8snetworkplumbingwg/sriov-network-operator#167 and a new image or use older SR-IOV operator

@e0ne e0ne force-pushed the upstraem-sriov branch 2 times, most recently from 4a6c051 to 08d800c Compare July 25, 2021 08:43
@abdallahyas
Copy link
Contributor

@e0ne The kind CI is failing because it is trying to read the sriov-operator images from the old values file, and because it is deleted, it is failing. A change in the CI will need to be done for this to work.

@abdallahyas
Copy link
Contributor

/retest-copy-right

@abdallahyas
Copy link
Contributor

@e0ne does this PR change the way to deploy the sriov-operator? also is it okay to use the upstream images for the sriov operator?

We need to override configDaemonNodeSelector to wait until MOFED
will be loaded.

Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
@e0ne e0ne force-pushed the upstraem-sriov branch 2 times, most recently from 1031d72 to a6deb89 Compare July 27, 2021 15:19
@e0ne e0ne marked this pull request as ready for review July 27, 2021 15:19
@e0ne e0ne force-pushed the upstraem-sriov branch 4 times, most recently from 7a54374 to b8559cc Compare July 28, 2021 17:40
@e0ne
Copy link
Collaborator Author

e0ne commented Jul 28, 2021

/retest-nic_operator_helm

@e0ne e0ne force-pushed the upstraem-sriov branch from b8559cc to bd99ece Compare July 28, 2021 21:26
@e0ne
Copy link
Collaborator Author

e0ne commented Jul 29, 2021

/retest-nic_operator_helm

1 similar comment
@e0ne
Copy link
Collaborator Author

e0ne commented Jul 29, 2021

/retest-nic_operator_helm

@e0ne
Copy link
Collaborator Author

e0ne commented Jul 29, 2021

/retest-nic_operator

@e0ne e0ne force-pushed the upstraem-sriov branch from bd99ece to ed3cf99 Compare July 29, 2021 12:26
We can't use SR-IOV Network Operator chart from the official repo until
k8snetworkplumbingwg/sriov-network-operator#167
will be merged and new chart will be punlished.

This patch syncs the latest changes from the upstrem to Network Operator
repo to deploy the lates version of the SR-IOV Network Operator.

Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
@e0ne
Copy link
Collaborator Author

e0ne commented Aug 1, 2021

/retest-nic_operator_helm

3 similar comments
@abdallahyas
Copy link
Contributor

/retest-nic_operator_helm

@abdallahyas
Copy link
Contributor

/retest-nic_operator_helm

@e0ne
Copy link
Collaborator Author

e0ne commented Aug 2, 2021

/retest-nic_operator_helm

@moshe010
Copy link
Collaborator

moshe010 commented Aug 3, 2021

@AbdYsn what is the status of the CI workaround? we want to merge it ASAP

@abdallahyas
Copy link
Contributor

/retest-nic_operator_helm

@abdallahyas
Copy link
Contributor

/retest-nic_operator_helm

3 similar comments
@e0ne
Copy link
Collaborator Author

e0ne commented Aug 3, 2021

/retest-nic_operator_helm

@abdallahyas
Copy link
Contributor

/retest-nic_operator_helm

@abdallahyas
Copy link
Contributor

/retest-nic_operator_helm

@moshe010 moshe010 merged commit acadeda into Mellanox:master Aug 3, 2021
@e0ne e0ne mentioned this pull request Aug 4, 2021
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants