Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.29] fix: bump to fedora:38 in dockerized tests, because 34 is missing #288

Merged
merged 1 commit into from
Oct 30, 2023
Merged

[release-0.29] fix: bump to fedora:38 in dockerized tests, because 34 is missing #288

merged 1 commit into from
Oct 30, 2023

Conversation

phoracek
Copy link
Member

What this PR does / why we need it:

Fedora 34 image is no longer available.

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 30, 2023
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2023
@phoracek
Copy link
Member Author

/override pull-e2e-ovs-cni

Unstable tests

@AlonaKaplan
Copy link
Collaborator

/lgtm

@kubevirt-bot
Copy link
Collaborator

@AlonaKaplan: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@phoracek
Copy link
Member Author

/override pull-e2e-ovs-cni

@phoracek
Copy link
Member Author

/override pull-e2e-ovs-cni-0.29

@0xFelix
Copy link
Contributor

0xFelix commented Oct 30, 2023

/lgtm
/retest

@kubevirt-bot
Copy link
Collaborator

@0xFelix: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@0xFelix 0xFelix mentioned this pull request Oct 30, 2023
Merged
@oshoval
Copy link
Member

oshoval commented Oct 30, 2023

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2023
@oshoval
Copy link
Member

oshoval commented Oct 30, 2023 •
edited
Loading

nit: please consider adding [release-0.29] to PR desc

@phoracek phoracek changed the title fix: bump to fedora:38 in dockerized tests, because 34 is missing [release-0.29] fix: bump to fedora:38 in dockerized tests, because 34 is missing Oct 30, 2023
@kubevirt-bot kubevirt-bot merged commit 1b49644 into k8snetworkplumbingwg:release-0.29 Oct 30, 2023
@oshoval oshoval mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oshoval oshoval

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@phoracek @kubevirt-bot @AlonaKaplan @0xFelix @oshoval @courtland