Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.29] chore: Update golang.org/x/* modules #284

Merged
merged 1 commit into from
Oct 31, 2023
Merged

[release-0.29] chore: Update golang.org/x/* modules #284

merged 1 commit into from
Oct 31, 2023

Conversation

0xFelix
Copy link
Contributor

@0xFelix 0xFelix commented Oct 30, 2023

What this PR does / why we need it:

Updated modules golang.org/x/* to the latest versions.

Special notes for your reviewer:

Release note:

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 30, 2023
@kubevirt-bot
Copy link
Collaborator

Hi @0xFelix. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 30, 2023
@0xFelix 0xFelix changed the title chore: Update golang.org/x/* modules [release-0.29] chore: Update golang.org/x/* modules Oct 30, 2023
@phoracek
Copy link
Member

/ok-to-test

@kubevirt-bot kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 30, 2023
@phoracek
Copy link
Member

/retest

@0xFelix
chore: Update golang.org/x/* modules
8aa7325 
Updated modules golang.org/x/* to the latest versions.

Signed-off-by: Felix Matouschek <[email protected]>
@0xFelix
Copy link
Contributor Author

0xFelix commented Oct 30, 2023

Waiting for #288

@0xFelix
Copy link
Contributor Author

0xFelix commented Oct 30, 2023

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2023
@phoracek
Copy link
Member

/retest

@phoracek
Copy link
Member

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2023
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix, phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2023
@oshoval
Copy link
Member

oshoval commented Oct 31, 2023 •
edited
Loading

Waiting for #288

merged, can we remove the hold ?

@phoracek
Copy link
Member

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2023
@kubevirt-bot kubevirt-bot merged commit e104b4b into k8snetworkplumbingwg:release-0.29 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@phoracek phoracek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xFelix @kubevirt-bot @phoracek @oshoval