Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new prefer-bundled-bin experimental flag #6420

Merged
merged 10 commits into from
Nov 21, 2022
Merged

Add new prefer-bundled-bin experimental flag #6420

merged 10 commits into from
Nov 21, 2022

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Nov 3, 2022 •
edited
Loading

Signed-off-by: Derek Nola [email protected]

Proposed Changes

  • Adds new prefer-bundled-bin flag which forces K3s to use its embedded tools/binaries over the host tools. This should help when dealing with OSes that have outdated or buggy tools (e.g. iptables v1.8.2 issues)

Types of Changes

Feature

Verification

Check logs for PATH infomation
Validate that host iptables (both host and k3s used nftables backend) can still see rules added by k3s iptables

iptables-nft -L
...
Chain KUBE-SERVICES (2 references)
target     prot opt source               destination         
REJECT     udp  --  anywhere             10.43.0.10           /* kube-system/kube-dns:dns has no endpoints */ udp dpt:domain reject-with icmp-port-unreachable
REJECT     tcp  --  anywhere             10.43.0.10           /* kube-system/kube-dns:dns-tcp has no endpoints */ tcp dpt:domain reject-with icmp-port-unreachable
REJECT     tcp  --  anywhere             10.43.26.109         /* kube-system/metrics-server:https has no endpoints */ tcp dpt:https reject-with icmp-port-unreachable
REJECT     tcp  --  anywhere             10.43.0.10           /* kube-system/kube-dns:metrics has no endpoints */ tcp dpt:9153 reject-with icmp-port-unreachable

Testing

Added clause to startup integration test

Linked Issues

#3117

User-Facing Change

Added new prefer-bundled-bin flag which force K3s to use its bundle binaries over that of the host tools

Further Comments

@dereknola dereknola requested a review from a team as a code owner November 3, 2022 19:59
@dereknola dereknola changed the title Add new aux-tools experimental flag Add new prefer-bundled-bin experimental flag Nov 3, 2022
brandond
brandond reviewed Nov 3, 2022
View reviewed changes
cmd/k3s/main.go Show resolved Hide resolved
pkg/cli/cmds/server.go Outdated Show resolved Hide resolved
brandond
brandond requested changes Nov 8, 2022
View reviewed changes
cmd/k3s/main.go Outdated Show resolved Hide resolved
cmd/k3s/main.go Outdated Show resolved Hide resolved
cmd/k3s/main.go Outdated Show resolved Hide resolved
@brandond brandond mentioned this pull request Nov 9, 2022
Closed
brandond
brandond reviewed Nov 11, 2022
View reviewed changes
cmd/k3s/main.go Outdated Show resolved Hide resolved
@dereknola
Remove dev log
74fc488 
Signed-off-by: Derek Nola <[email protected]>
@dereknola
Fix code validation
dde2d3c 
Signed-off-by: Derek Nola <[email protected]>
@dereknola
go mod tidy
d6c07ec 
Signed-off-by: Derek Nola <[email protected]>
@dereknola dereknola merged commit 0f52088 into k3s-io:master Nov 21, 2022
@dereknola dereknola deleted the aux_tools branch November 22, 2022 17:42
@dereknola dereknola mentioned this pull request Nov 22, 2022
Merged
brandond pushed a commit to brandond/k3s that referenced this pull request Dec 1, 2022
@dereknola @brandond
Add new prefer-bundled-bin experimental flag (k3s-io#6420)
65320bf 
* initial prefer-bundled-bin ci change
* Add startup testlet
* Convert parsing to pflag library
* Fix code validation
* go mod tidy

Signed-off-by: Derek Nola <[email protected]>
(cherry picked from commit 0f52088)
Signed-off-by: Brad Davidson <[email protected]>
brandond pushed a commit to brandond/k3s that referenced this pull request Dec 1, 2022
@dereknola @brandond
Add new prefer-bundled-bin experimental flag (k3s-io#6420)
fa84542 
* initial prefer-bundled-bin ci change
* Add startup testlet
* Convert parsing to pflag library
* Fix code validation
* go mod tidy

Signed-off-by: Derek Nola <[email protected]>
(cherry picked from commit 0f52088)
Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond mentioned this pull request Dec 1, 2022
Merged
brandond pushed a commit to brandond/k3s that referenced this pull request Dec 1, 2022
@dereknola @brandond
Add new prefer-bundled-bin experimental flag (k3s-io#6420)
9f2cfa3 
* initial prefer-bundled-bin ci change
* Add startup testlet
* Convert parsing to pflag library
* Fix code validation
* go mod tidy

Signed-off-by: Derek Nola <[email protected]>
(cherry picked from commit 0f52088)
Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond mentioned this pull request Dec 1, 2022
Merged
brandond pushed a commit that referenced this pull request Dec 2, 2022
@dereknola @brandond
Add new prefer-bundled-bin experimental flag (#6420)
f457794 
* initial prefer-bundled-bin ci change
* Add startup testlet
* Convert parsing to pflag library
* Fix code validation
* go mod tidy

Signed-off-by: Derek Nola <[email protected]>
(cherry picked from commit 0f52088)
Signed-off-by: Brad Davidson <[email protected]>
brandond pushed a commit that referenced this pull request Dec 2, 2022
@dereknola @brandond
Add new prefer-bundled-bin experimental flag (#6420)
8784eab 
* initial prefer-bundled-bin ci change
* Add startup testlet
* Convert parsing to pflag library
* Fix code validation
* go mod tidy

Signed-off-by: Derek Nola <[email protected]>
(cherry picked from commit 0f52088)
Signed-off-by: Brad Davidson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandowns briandowns briandowns approved these changes

@brandond brandond brandond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dereknola @brandond @briandowns