Deal with repeated arguments

Signed-off-by: Derek Nola <[email protected]>

cmd/k3s/main.go

@@ -104,16 +104,17 @@ func findDataDir() string {
 // findPreferBundledBin searches for prefer-bundled-bin from the CLI args and config file.
 func findPreferBundledBin(args []string) bool {
 	preferRes := configfilearg.MustFindString(args, "prefer-bundled-bin")
+	flagName := "--prefer-bundled-bin"
 	for i, arg := range args {
-		flagName := "--prefer-bundled-bin"
 		if flagName == arg {
 			if len(args) > i+1 {
-				if res, err := strconv.ParseBool(args[i+1]); err == nil {
-					return res
+				if _, err := strconv.ParseBool(args[i+1]); err == nil {
+					preferRes = args[i+1]
 				}
+			} else {
+				//Naked flag, assume true
+				preferRes = "true"
 			}
-			//Naked flag, assume true
-			return true
 		} else if strings.HasPrefix(arg, flagName+"=") {
 			preferRes = arg[len(flagName)+1:]
 		}

cmd/k3s/main_test.go

@@ -48,6 +48,11 @@ func Test_UnitFindPreferBundledBin(t *testing.T) {
 			args: []string{"--abcd", "--prefer-bundled-bin", "false", "--efgh"},
 			want: false,
 		},
+		{
+			name: "Repeated arguments",
+			args: []string{"--abcd", "--prefer-bundled-bin", "false", "--prefer-bundled-bin"},
+			want: true,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {