Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPLEMENT] Expose more captions callbacks and events #99

Merged

Conversation

edougher
Copy link
Collaborator

What does this Pull Request do?

Adds (3)three additional captions events:

  1. getCurrentCaptions: Returns index of current caption.
  2. onCaptionsChanged: Fires when the caption track has changed. Returns index of current caption.
  3. onCaptionsList: Fires when the caption tracks become available. Returns current index of caption in use. -1 if no caption is being used. Also returns an array of captions.

Why is this Pull Request needed?

Provides developer greater visibility/control of the Captions feature.

Are there any points in the code the reviewer needs to double check?

No

Are there any Pull Requests open in other repos which need to be merged with this?

No

Addresses Issue(s):

GitHub Issue

@edougher edougher requested a review from a team as a code owner October 22, 2024 16:10
Copy link
Collaborator

@Jmilham21 Jmilham21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please remove the unecessary whitespace in SingleExample.js and it's good to go for me.

Example/app/jsx/screens/SingleExample.js Outdated Show resolved Hide resolved
@Jmilham21 Jmilham21 self-requested a review October 23, 2024 17:04
Copy link
Collaborator

@Jmilham21 Jmilham21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants