Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPLEMENT] Expose more captions callbacks and events #45

Closed
Jmilham21 opened this issue Jun 7, 2024 · 2 comments
Closed

[IMPLEMENT] Expose more captions callbacks and events #45

Jmilham21 opened this issue Jun 7, 2024 · 2 comments
Labels
good first issue Good for newcomers Groomed JWP team has reviewed the ticket and deemed it necessary in-progress Actively being worked on by the asignee

Comments

@Jmilham21
Copy link
Collaborator

Jmilham21 commented Jun 7, 2024

What needs to be implemented
Expose:

How should it be implemented

  • Follow convention and pass the native event to the JS with the values from the Native Event.
  • Follow convention for adding a bridged callback to native SDKs in JS.

Acceptance Criteria

  • Native events are bubbled to the JS
  • The new events are defined in index.js and index.d.ts
  • iOS and Android are both covered
  • Add function for getCurrentCaptions in JS / Native
  • Add demo of this in Example app OR in README.md
    • This is now optional. We will update our props and callback list soon

Additional context
If there are any other captions events or helper functions you see, feel free to implement.

@Jmilham21 Jmilham21 added needs-grooming Has not been reviewed by codeowners for scope/validation good first issue Good for newcomers Groomed JWP team has reviewed the ticket and deemed it necessary and removed needs-grooming Has not been reviewed by codeowners for scope/validation labels Jun 7, 2024
@Jmilham21
Copy link
Collaborator Author

It'd be worth considering the onCaptionText event as well. This is helpful for those who want to render captions outside of the player.

@Jmilham21 Jmilham21 added the in-progress Actively being worked on by the asignee label Oct 21, 2024
@Jmilham21
Copy link
Collaborator Author

Finished with the work found here: #99

This will be in the next release to NPM (version TBD)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Groomed JWP team has reviewed the ticket and deemed it necessary in-progress Actively being worked on by the asignee
Projects
None yet
Development

No branches or pull requests

2 participants