-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(connector): [Klarna] Add shipping Address in Klarna Session and Payment Request #4836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swangi-kumari
added
A-connector-integration
Area: Connector integration
C-refactor
Category: Refactor
labels
May 31, 2024
swangi-kumari
changed the title
reafactor(connector): [Klarna] Add shipping Address in Klarna Session and Payment Request
refactor(connector): [Klarna] Add shipping Address in Klarna Session and Payment Request
May 31, 2024
SamraatBansal
approved these changes
May 31, 2024
Comment on lines
+214
to
+217
shipping_address | ||
.clone() | ||
.address | ||
.and_then(|shipping_address_details| shipping_address_details.first_name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can avoid clone on the shipping address and have clone only on the required field
Suggested change
shipping_address | |
.clone() | |
.address | |
.and_then(|shipping_address_details| shipping_address_details.first_name) | |
shipping_address | |
.address.as_ref() | |
.and_then(|shipping_address_details| shipping_address_details.first_name.clone()) |
This can be done in other places as well
Narayanbhat166
approved these changes
May 31, 2024
pixincreate
added a commit
that referenced
this pull request
Jun 4, 2024
…atus_pt * 'main' of github.com:juspay/hyperswitch: chore(version): 2024.06.04.0 fix: include client_version and client_source in retried payments (#4826) refactor(users): Changes for Home and Signout APIs for TOTP Redis flows (#4851) feat(users): Create config for TOTP Issuer (#4776) feat(multitenancy): add support for multitenancy and handle the same in router, producer, consumer, drainer and analytics (#4630) feat(connector): [AUTHORIZEDOTNET] Support payment_method_id in recurring mandate payment (#4841) refactor(connector): airwallex convert init payment to preprocessing (#4842) feat(router): send `three_ds_requestor_url` in authentication_response for external 3ds flow (#4828) feat(consolidated-kafka-events): add consolidated kafka payment events (#4798) refactor(connector): [Klarna] Add shipping Address in Klarna Session and Payment Request (#4836) fix(connector): make few fields optional in struct NetceteraErrorDetails (#4827) chore(cypress): remove logs that expose `globalState` (#4844)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add shipping Address in Klarna Session and Payment Request
Additional Changes
Motivation and Context
How did you test it?
Create a payment via sdk with capture_method =
automatic
and use the shipping address which is provided belowCheck in klarna dashboard if shipping details are being populated correctly for the paymnet.
Checklist
cargo +nightly fmt --all
cargo clippy