refactor(connector): airwallex convert init payment to preprocessing #4842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrithikesh026
added
A-core
jarnura
approved these changes
Jun 3, 2024
SanchithHegde
approved these changes
Jun 3, 2024
likhinbopanna
deleted the
convert-init-payment-flow-to-preprocessing-airwallex
branch
| @@ -1885,6 +1885,14 @@ where | |||
| dyn api::Connector: | |||
| services::api::ConnectorIntegration<F, Req, router_types::PaymentsResponseData>, | |||
| { | |||
| if !is_operation_complete_authorize(&operation) | |||
There was a problem hiding this comment.
why are we checking for the operation here?
can you use
There was a problem hiding this comment.
fn preprocessing_steps is overridden for Both Authorize and CompleteAuthorize flows.
But I want to call preprocessing_steps only during Authorize flow for Airwallex.
Within fn preprocessing_steps implementation of Authorize Flow, we are calling fn authorize_preprocessing_steps
pixincreate
added a commit
that referenced
this pull request
Jun 4, 2024
…atus_pt * 'main' of github.com:juspay/hyperswitch: chore(version): 2024.06.04.0 fix: include client_version and client_source in retried payments (#4826) refactor(users): Changes for Home and Signout APIs for TOTP Redis flows (#4851) feat(users): Create config for TOTP Issuer (#4776) feat(multitenancy): add support for multitenancy and handle the same in router, producer, consumer, drainer and analytics (#4630) feat(connector): [AUTHORIZEDOTNET] Support payment_method_id in recurring mandate payment (#4841) refactor(connector): airwallex convert init payment to preprocessing (#4842) feat(router): send `three_ds_requestor_url` in authentication_response for external 3ds flow (#4828) feat(consolidated-kafka-events): add consolidated kafka payment events (#4798) refactor(connector): [Klarna] Add shipping Address in Klarna Session and Payment Request (#4836) fix(connector): make few fields optional in struct NetceteraErrorDetails (#4827) chore(cypress): remove logs that expose `globalState` (#4844)
pixincreate
removed
the
S-waiting-on-review
pixincreate
added a commit
that referenced
this pull request
Jun 4, 2024
* 'main' of github.com:juspay/hyperswitch: feat(cypress): Add service level testing for Payouts (#4744) feat(auth): Create and use `SinglePurposeOrLoginTokenAuth` (#4830) refactor(connector): [Adyen] handle redirection error response (#4862) refactor(api_models): rename Card struct for payouts to avoid overrides in auto generated open API spec (#4861) chore(version): 2024.06.04.1 fix(connector): [Adyen]add required fields for afterpay clearpay (#4858) chore(version): 2024.06.04.0 fix: include client_version and client_source in retried payments (#4826) refactor(users): Changes for Home and Signout APIs for TOTP Redis flows (#4851) feat(users): Create config for TOTP Issuer (#4776) feat(multitenancy): add support for multitenancy and handle the same in router, producer, consumer, drainer and analytics (#4630) feat(connector): [AUTHORIZEDOTNET] Support payment_method_id in recurring mandate payment (#4841) refactor(connector): airwallex convert init payment to preprocessing (#4842) feat(router): send `three_ds_requestor_url` in authentication_response for external 3ds flow (#4828) feat(consolidated-kafka-events): add consolidated kafka payment events (#4798)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Removed
fn execute_pretasks()from Authorize ConnectorIntegration implementation on Airwallex.fn execute_pretasks()was calling an api to retrieve a reference_id and populate router_data. I've moved this logic to core. So that this operation will be done in preprocessing flow.Also updated Airwallex postman collection.
Additional Changes
Motivation and Context
How did you test it?
Manual.
Ran the airwallex postman collection to test sanity.
Checklist
cargo +nightly fmt --allcargo clippy