Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: moved delete all sample data from account settings #1034

Merged
merged 7 commits into from
Jul 22, 2024
Merged

fix: moved delete all sample data from account settings #1034

merged 7 commits into from
Jul 22, 2024

Conversation

Riddhiagrawal001
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

image

Motivation and Context

How did you test it?

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@Riddhiagrawal001 Riddhiagrawal001 added the S-blocked Status: Blocked on something else or other implementation work label Jul 22, 2024
@Riddhiagrawal001 Riddhiagrawal001 self-assigned this Jul 22, 2024
@Riddhiagrawal001 Riddhiagrawal001 requested a review from a team as a code owner July 22, 2024 06:56
@Riddhiagrawal001 Riddhiagrawal001 linked an issue Jul 22, 2024 that may be closed by this pull request
[FEATURE] Add Hyperswitch PCI Certificate #967
Closed
@Riddhiagrawal001 Riddhiagrawal001 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-blocked Status: Blocked on something else or other implementation work labels Jul 22, 2024
gitanjli525
gitanjli525 requested changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@gitanjli525 gitanjli525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to remove "delete sample data" from Account Settings also?

@Riddhiagrawal001
Copy link
Contributor Author

@gitanjli525
Already handled in #1027

@gitanjli525
Copy link
Contributor

Can we fix this ?
image

@gitanjli525
Copy link
Contributor

Can we position center the bin icon?
image

JeevaRamu0104
JeevaRamu0104 previously approved these changes Jul 22, 2024
View reviewed changes
@Riddhiagrawal001
Copy link
Contributor Author

@gitanjli525
image

@Riddhiagrawal001 Riddhiagrawal001 added this pull request to the merge queue Jul 22, 2024
Merged via the queue into main with commit be4b048 Jul 22, 2024
5 of 6 checks passed
@Riddhiagrawal001 Riddhiagrawal001 deleted the delete-sample-data-changes branch July 22, 2024 11:27
@github-actions github-actions bot removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jul 22, 2024
@github-actions github-actions bot added the Closed Applied to issues or pull requests that have been successfully resolved or completed label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

@gitanjli525 gitanjli525 gitanjli525 approved these changes

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

Assignees

@Riddhiagrawal001 Riddhiagrawal001

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Hyperswitch PCI Certificate
4 participants
@Riddhiagrawal001 @gitanjli525 @PritishBudhiraja @JeevaRamu0104