Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PCI certificate addition under compliance section #1027

Merged
merged 16 commits into from
Jul 24, 2024
Merged

feat: PCI certificate addition under compliance section #1027

merged 16 commits into from
Jul 24, 2024

Conversation

Riddhiagrawal001
Copy link
Contributor

@Riddhiagrawal001 Riddhiagrawal001 commented Jul 19, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

dss_certificate_url hosted url of the compliance file
Uploading image.png…

Motivation and Context

How did you test it?

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@Riddhiagrawal001 Riddhiagrawal001 added the S-blocked Status: Blocked on something else or other implementation work label Jul 19, 2024
@Riddhiagrawal001 Riddhiagrawal001 self-assigned this Jul 19, 2024
@Riddhiagrawal001 Riddhiagrawal001 requested a review from a team as a code owner July 19, 2024 09:19
@Riddhiagrawal001 Riddhiagrawal001 linked an issue Jul 19, 2024 that may be closed by this pull request
[FEATURE] Add Hyperswitch PCI Certificate #967
Closed
@Riddhiagrawal001 Riddhiagrawal001 mentioned this pull request Jul 22, 2024
Merged
10 tasks
@Riddhiagrawal001 Riddhiagrawal001 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-blocked Status: Blocked on something else or other implementation work labels Jul 22, 2024
PritishBudhiraja
PritishBudhiraja previously approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@PritishBudhiraja PritishBudhiraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :')

gitanjli525
gitanjli525 previously approved these changes Jul 23, 2024
View reviewed changes
@PritishBudhiraja PritishBudhiraja added this pull request to the merge queue Jul 23, 2024
@PritishBudhiraja PritishBudhiraja removed this pull request from the merge queue due to a manual request Jul 23, 2024
@JeevaRamu0104 JeevaRamu0104 added S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author feature feature and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jul 24, 2024
@Riddhiagrawal001 Riddhiagrawal001 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author labels Jul 24, 2024
@Riddhiagrawal001 Riddhiagrawal001 added this pull request to the merge queue Jul 24, 2024
Merged via the queue into main with commit a84d8d8 Jul 24, 2024
5 of 6 checks passed
@Riddhiagrawal001 Riddhiagrawal001 deleted the pci-certificate-addition branch July 24, 2024 09:07
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed feature feature labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

@sagarnaikjuspay sagarnaikjuspay sagarnaikjuspay left review comments

@gitanjli525 gitanjli525 gitanjli525 left review comments

Assignees

@Riddhiagrawal001 Riddhiagrawal001

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Hyperswitch PCI Certificate
5 participants
@Riddhiagrawal001 @PritishBudhiraja @gitanjli525 @JeevaRamu0104 @sagarnaikjuspay