Bump notebook version to 5.2.2 #150
Conversation
|
Big thanks to @grantnestor for cutting a release for us! |
|
Thanks @gnestor 🍰 |
|
Not sure why Travis is failing some tests. |
|
Perhaps since the latest notebook release is not yet in conda and/or conda forge. |
|
I think notebook 5.2.2 has not made it to conda yet. All failures seem
conda related.
…On Tue, Nov 28, 2017 at 6:06 PM, Carol Willing ***@***.***> wrote:
***@***.**** commented on this pull request.
Travis issues.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#150 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB23ue1vLAzJXPi9EVV7LynavC7Cm4hks5s7LwNgaJpZM4QuTOt>
.
--
Yuvi Panda T
http://yuvi.in/blog
|
|
Yes I think this line is failing: |
5.2.2 doesn't exist in anaconda channels...
Doesn't have 5.2 either
|
@yuvipanda Are you just dropping back to 5.0 for the legacy build? If we add conda-forge channel |
|
Looks like @minrk merged 5.2.2 into conda forge a couple of hours ago https://github.com/conda-forge/notebook-feedstock |
|
Anaconda typically lags. Continuum folks may have a guesstimate. |
|
@yuvipanda I think that this could be merged as is with legacy as 5.0. Your call. |
|
@willingc yep, I think we should merge + deploy. Fixing jupyterhub/binderhub#211 before blog posts would be great! |
|
Go for it @yuvipanda |
- Change image prefix so all current images are invalidated. This gets in the crucial fix jupyterhub/repo2docker#150 - Change image prefix to have repo2docker commit hash on it.
|
I think it makes sense to leave legacy Dockerfiles with an older version basically forever. They shouldn't be updated. |
|
@minrk do they also suffer from jupyterhub/binderhub#211? |
|
@yuvipanda they do. But it will only affect other binders that also use legacy dockerfiles. |
|
@minrk ok! if you're ok with it so am I :) |
Bump notebook version to 5.2.2
Brings in jupyter/notebook#2959 to fix
jupyterhub/binderhub#211