Bump repo2docker version #173
Conversation
- Change image prefix so all current images are invalidated. This gets in the crucial fix jupyterhub/repo2docker#150 - Change image prefix to have repo2docker commit hash on it.
| @@ -4,7 +4,7 @@ binderhub: | |||
| - mybinder.org | |||
|
|
|||
| registry: | |||
| prefix: gcr.io/binder-prod/prod-v4-1- | |||
| prefix: gcr.io/binder-prod/r2d-3cd4519 | |||
There was a problem hiding this comment.
Is this a precedent where we should update the prefix every time we bump repo2docker in order to invalidate all builds?
There was a problem hiding this comment.
I don't think we should. We should only do so when we have a breaking change we want everyone to get, such as this (or the artful deploy). However, there's nothing wrong with bumping it up every time, and definitely leads to more consistent results. Am happy with either...
There was a problem hiding this comment.
haha, I love how I started with "I don't think we should" and ended with "Am happy with either" lol. I meant "I don't think we do", in that we don't have precedent.
There was a problem hiding this comment.
OK. I think if it's less frequent, maybe tying it to version numbers in repo2docker is the way to go in the long run, but this works for now, at least.
gets in the crucial fix Bump notebook version to 5.2.2 repo2docker#150