Fix failure to restore deleted files (use raw output of git ls-files to avoid quoting unicode) #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manics
changed the title
consideRatio
reviewed
Oct 3, 2020
| 'git', 'ls-files', '--deleted' | ||
| ], cwd=self.repo_dir).decode().strip().split('\n') | ||
| 'git', 'ls-files', '--deleted', '-z' | ||
| ], cwd=self.repo_dir).decode().strip().split('\0') |
There was a problem hiding this comment.
Ah, this LGTM, I wondered about the \0 split first.
-z
\0 line termination on output and do not quote filenames. See OUTPUT below for more information.
...
Without the -z option, pathnames with "unusual" characters are quoted as explained for the configuration variable core.quotePath (see git-config(1)).
Using -z the filename is output verbatim and the line is terminated by a NUL byte.
|
@manics excellent that you also added a test, this looks great to me! Since this fixes a know bug, and has a test, and LGTM, I'll go ahead and merge this right away. |
consideRatio
approved these changes
Oct 3, 2020
consideRatio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #121
git ls-filesdefaults to using octal escapes for non-ascii characters. Passing-zdisables this.