Nbgitpuller fails to reset deleted files

[stv0g]

Bug description

Nbgitpuller fails to restore a deleted file by the user.

This error might be caused be the special unicode characters in the filename.
Or this might be just a coincidence

Expected behaviour

Nbgitpuller should restore the deleted files without raising an exception.

Actual behaviour

How to reproduce

1. Pull a repo via gitpuller
2. Delete a file with sepcial characters
3. Pull again

Your personal set up

• OS: MacOS, Chrome

• Version:

• Configuration: JupyterHub + Kubespawner, Execution of gitpuller via lifecyle hook

[manics]

Reproduced today with current master (5481b59)

git init src
cd src
touch unicode🙂.txt
git add unicode🙂.txt
git commit -m 'add unicode'
cd ..

gitpuller file:///src master dest
rm dest/unicode🙂.txt
gitpuller file:///src master dest

output:

$ git fetch

$ git checkout origin/master -- "unicode\360\237\231\202.txt"

error: pathspec '"unicode\360\237\231\202.txt"' did not match any file(s) known to git

Traceback (most recent call last):
  File "/usr/local/bin/gitpuller", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.8/site-packages/nbgitpuller/pull.py", line 250, in main
    for line in GitPuller(
  File "/usr/local/lib/python3.8/site-packages/nbgitpuller/pull.py", line 86, in pull
    yield from self.update()
  File "/usr/local/lib/python3.8/site-packages/nbgitpuller/pull.py", line 203, in update
    yield from self.reset_deleted_files()
  File "/usr/local/lib/python3.8/site-packages/nbgitpuller/pull.py", line 115, in reset_deleted_files
    yield from execute_cmd(['git', 'checkout', 'origin/{}'.format(self.branch_name), '--', filename], cwd=self.repo_dir)
  File "/usr/local/lib/python3.8/site-packages/nbgitpuller/pull.py", line 45, in execute_cmd
    raise subprocess.CalledProcessError(ret, cmd)
subprocess.CalledProcessError: Command '['git', 'checkout', 'origin/master', '--', '"unicode\\360\\237\\231\\202.txt"']' returned non-zero exit status 1.

Works fine with a non-unicode filename.

[consideRatio]

@stv0g @manics :hear: 🎉 thanks for your work!