Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PyPI url #259

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Fix PyPI url #259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
pkg_json = json.loads((HERE / "jupyterlab-server-proxy" / "package.json").read_bytes())

setup_args = dict(
name=name,
name=name.replace("_", "-"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other references to the name, do you think it is correct for those to not be changes alongside this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the other name references should keep the _ because we're actually referencing a directory in those cases. The entire npm build will break if we rename the original name variable (I tried that first, actually).

By only changing it in the setup_args I think the entire build process stays the same and the only thing that changes is the name of the .tar.gz file.

version=pkg_json["version"],
url=pkg_json["homepage"],
author=pkg_json["author"]["name"],
Expand Down