Fix PyPI url #259
Merged
Fix PyPI url #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janjagusch
force-pushed
the
fix-pypi-url
branch
from
49cf2bd to
1a79a03
Compare
|
@consideRatio, this should solve our issue in conda-forge/jupyter-server-proxy-feedstock#20 as well. :) |
| @@ -73,7 +73,7 @@ | |||
| pkg_json = json.loads((HERE / "jupyterlab-server-proxy" / "package.json").read_bytes()) | |||
|
|
|||
| setup_args = dict( | |||
| name=name, | |||
| name=name.replace("_", "-"), | |||
There was a problem hiding this comment.
There are other references to the name, do you think it is correct for those to not be changes alongside this?
There was a problem hiding this comment.
I believe the other name references should keep the _ because we're actually referencing a directory in those cases. The entire npm build will break if we rename the original name variable (I tried that first, actually).
By only changing it in the setup_args I think the entire build process stays the same and the only thing that changes is the name of the .tar.gz file.
5 tasks
|
@janjagusch nice I've released 3.0.1 now with this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #258
The
.tar.gzfile now has the correct name.