This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Clean up utils and use external url functions #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,7 +9,8 @@ | |||
| "path-posix": "^1.0.0", | |||
| "phosphor-disposable": "^1.0.5", | |||
| "phosphor-signaling": "^1.2.0", | |||
| "requirejs": "^2.2.0" | |||
| "requirejs": "^2.2.0", | |||
| "url": "^0.11.0" | |||
There was a problem hiding this comment.
FYI, I noticed that both url and the path module we are using are missing upstream bugfixes from npm (cf. defunctzombie/node-url#24). They may be better than if we tried to write something from scratch, though, so +1 to not immediately trying to write our own.
There was a problem hiding this comment.
I'm actually not using url, it should have been url-join, since url didn't offer anything over posix-path. Agreed that we don't want to have our own path implementation.
|
Note: I am going to use |
blink1073
changed the title
blink1073
changed the title
|
Ready. |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not find a suitable ajax library that has the features we are using.
cf jupyterlab/jupyterlab#446