Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to fix tests #4039

Merged
merged 1 commit into from
Oct 2, 2018
Merged

try to fix tests #4039

merged 1 commit into from
Oct 2, 2018

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented Sep 26, 2018

Json schema pre seem to require attrs>17.3.0.

So pin it in tests.

Should solve issues of people like @Hyaxia in #4038

Let's see if the test pass only with this change.

@Hyaxia
Copy link
Contributor

Hyaxia commented Sep 26, 2018

Looks like travis gives the same errors as the one I'm having at #4038

@Carreau
Copy link
Member Author

Carreau commented Sep 26, 2018

Looks like travis gives the same errors as the one I'm having at #4038

Yeah I pinned to >=17.3 instead of >=17.4. I've pushed changes.

@Hyaxia
Copy link
Contributor

Hyaxia commented Sep 29, 2018

Hey, it looks like the tests are doing problems again.
#4036 I commited few other changes and the tests now fail in appveyor.
Fail at the package installation part, at pip install .[test].

It looks like the problem is something with the setuptools or the pip itself,
I have tried to play a little bit with the configuration for the appveyor and see if it works if i downgrade
the different installations but it doesn't seem to work.

getting error pip._vendor.packaging.requirements.InvalidRequirement: Invalid requirement, parse error at "'; extra '"

@jph00
Copy link

jph00 commented Sep 30, 2018

FYI it appears that this bug is breaking all environments that are using jupyter - for instance: http://forums.fast.ai/t/conda-env-update-error-on-paperspace/23483

If this is the source of this recent issue, perhaps you could revert the recent change that caused it until it's fixed?

@Hyaxia
Copy link
Contributor

Hyaxia commented Sep 30, 2018

@jph00 see my temporary fix for the bug 4c1d62f
It seems like there is a problem with the current of nbconvert or its dependencies that
anaconda installs, so we just use pip instead.

@jph00
Copy link

jph00 commented Sep 30, 2018

Thanks for the tip!

@blink1073
Copy link
Contributor

Thanks @Carreau, forging ahead!

@blink1073 blink1073 merged commit fa7b40b into jupyter:master Oct 2, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants