-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try to fix tests #4039
try to fix tests #4039
Conversation
Looks like travis gives the same errors as the one I'm having at #4038 |
a15fb0a
to
7d211d4
Compare
Yeah I pinned to >=17.3 instead of >=17.4. I've pushed changes. |
Hey, it looks like the tests are doing problems again. It looks like the problem is something with the setuptools or the pip itself, getting error |
FYI it appears that this bug is breaking all environments that are using jupyter - for instance: http://forums.fast.ai/t/conda-env-update-error-on-paperspace/23483 If this is the source of this recent issue, perhaps you could revert the recent change that caused it until it's fixed? |
Thanks for the tip! |
Thanks @Carreau, forging ahead! |
Json schema pre seem to require attrs>17.3.0.
So pin it in tests.
Should solve issues of people like @Hyaxia in #4038
Let's see if the test pass only with this change.