Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added metrics for currently running terminals and labeled by type kernels #4036

Merged
merged 6 commits into from
Oct 2, 2018
Merged

Added metrics for currently running terminals and labeled by type kernels #4036

merged 6 commits into from
Oct 2, 2018

Conversation

Hyaxia
Copy link
Contributor

@Hyaxia Hyaxia commented Sep 26, 2018

Moved the 'metrics' file to a new package named 'promethues'.
Then split the file into two files, one containing the metrics themselves, the other containing any function that have something to do with prometheus.

Finally, Added new metrics into the prometheus.metrics file that represent the number of running terminals and added the functionality for that metric to be recorded in the terminal.api_handlers file.

relevant issue #3682

Then split the file into two files, one containing the metrics themselves, the other containing any function that have something to do with prometheus.

Finally, Added new metrics into the prometheus.metrics file that represent the number of running terminals and added the functionality for that metric to be recorded in the terminal.api_handlers file.
@Hyaxia
Copy link
Contributor Author

Hyaxia commented Sep 26, 2018

Its wierd that it failed...
All i have changed way the python code and I am able to run the jupyter notebook perfectly fine...
All of the errors say that it has failed running python -m notebook.jstest notebook, no idea why that is...
Can anyone explain?

@Hyaxia
Copy link
Contributor Author

Hyaxia commented Sep 26, 2018

Feels like the problem is not with my code but rather the way i uploaded the changes...
Can anybody explain me how to do it in the right way? there is no reason for this error to occur because of my code... (or atleast i cant find one)

@Carreau
Copy link
Member

Carreau commented Sep 26, 2018

I've pushed the fix of #4039 to your branch to hopefully fix the test suite.

@Hyaxia Hyaxia changed the title Added metrics for total terminals running and few other little changes Added metrics for currently running terminals and labeled by type kernels Sep 29, 2018
`RequirementParseError(str(e)) pip._vendor.pkg_resources.RequirementParseError: Invalid requirement, parse error at “’; extra '`
@blink1073
Copy link
Contributor

LGTM, thanks!

@blink1073 blink1073 merged commit dfcea5b into jupyter:master Oct 2, 2018
@blink1073 blink1073 added this to the 6.0 milestone Oct 2, 2018
@Hyaxia Hyaxia deleted the metrics_terminal branch October 2, 2018 21:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants