Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeprecate validate(nb, relax_add_props=True) #343

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Undeprecate validate(nb, relax_add_props=True) #343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions nbformat/validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ def validate(
ref: Optional[str] = None,
version: Optional[int] = None,
version_minor: Optional[int] = None,
relax_add_props: bool = _deprecated, # type: ignore
relax_add_props: bool = False,
nbjson: Any = None,
repair_duplicate_cell_ids: bool = _deprecated, # type: ignore
strip_invalid_metadata: bool = _deprecated, # type: ignore
Expand All @@ -420,11 +420,10 @@ def validate(
version : int
version_minor : int
relax_add_props : bool
Deprecated since 5.5.0 - will be removed in the future.
Wether to allow extra property in the Json schema validating the
notebook.
Wether to allow extra properties in the JSON schema validating the notebook.
When True, all known fields are validated, but unknown fields are ignored.
nbjson
repair_duplicate_cell_ids : boolny
repair_duplicate_cell_ids : bool
Deprecated since 5.5.0 - will be removed in the future.
strip_invalid_metadata : bool
Deprecated since 5.5.0 - will be removed in the future.
Expand All @@ -447,11 +446,6 @@ def validate(
"""
assert isinstance(ref, str) or ref is None

if relax_add_props is _deprecated:
relax_add_props = False
else:
_dep_warn("relax_add_props")

if strip_invalid_metadata is _deprecated:
strip_invalid_metadata = False
else:
Expand Down