Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeprecate validate(nb, relax_add_props=True) #343

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

minrk
Copy link
Member

@minrk minrk commented Jan 12, 2023

There is no equivalent behavior in normalize, so I don't think this shouldn't have been deprecated along with the other normalizing steps. relax_add_props is purely related to validation, not normalization since no changes are made, it only changes what is checked. The case for it still exists and is still relevant (in nbconvert preprocessor validation), so I think it should be kept.

This change (respecting the deprecation in nbconvert) has caused notebooks to fail on nbviewer: https://nbviewer.org/github/ibtassam1/SQL_Vancouver/blob/03f9f1e5dbd2c3e13965c01d125f5c9ab371d696/Vancouver%20Public%20Services_v3.ipynb

Deprecation was added in #282

there is no equivalent behavior in normalize, so this shouldn't have been deprecated
along with the other normalizing steps.
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 1eefc29 into jupyter:main Jan 12, 2023
@minrk minrk deleted the undeprecate-relax-add-props branch January 12, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants